threads / patch / 33313

patchgit help config: s/insn/instruction/

Subject: [PATCH] git help config: s/insn/instruction/

## tl;dr

4 messages between Mar 27, 2013 and Mar 28, 2013. Diffs are folded; open one to read it.

replies: 3people: 2as markdown or json

Matthias Krüger· Mar 27, 2013, 22:53 UTC · lore

"insn" appears to be an in-code abbreviation and should not appear in manual/help pages.
---
 Documentation/config.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to Documentation/config.txt +1 −1

diff --git a/Documentation/config.txt b/Documentation/config.txt
index c1f435f..f79184c 100644
--- a/Documentation/config.txt
+++ b/Documentation/config.txt
@@ -555,7 +555,7 @@ core.commentchar::
 	(default '#').
 
 sequence.editor::
-	Text editor used by `git rebase -i` for editing the rebase insn file.
+	Text editor used by `git rebase -i` for editing the rebase instruction file.
 	The value is meant to be interpreted by the shell when it is used.
 	It can be overridden by the `GIT_SEQUENCE_EDITOR` environment variable.
 	When not configured the default commit message editor is used instead.

-- 
1.8.2

Junio C Hamano· Mar 28, 2013, 05:59 UTC · re: Matthias Krüger · lore

Re: [PATCH] git help config: s/insn/instruction/

Matthias Krüger <matthias.krueger@famsik.de> writes:

> "insn" appears to be an in-code abbreviation and should not appear in manual/help pages.
> ---

Thanks; sign-off?

Matthias Krüger· Mar 28, 2013, 08:27 UTC · re: Junio C Hamano · lore

Re: [PATCH] git help config: s/insn/instruction/

On 03/28/2013 06:59 AM, Junio C Hamano wrote:

Show 5 quoted lines

> Matthias Krüger <matthias.krueger@famsik.de> writes:
>
>> "insn" appears to be an in-code abbreviation and should not appear in manual/help pages.
>> ---
> Thanks; sign-off?

Oops, sorry.

Signed-off-by: Matthias Krüger <matthias.krueger@famsik.de>

(Is this sufficient or do I have to re-send the patch with the sign-off line?)

Junio C Hamano· Mar 28, 2013, 15:55 UTC · re: Matthias Krüger · lore

Re: [PATCH] git help config: s/insn/instruction/

Matthias Krüger <matthias.krueger@famsik.de> writes:

Show 12 quoted lines

> On 03/28/2013 06:59 AM, Junio C Hamano wrote:
>> Matthias Krüger <matthias.krueger@famsik.de> writes:
>>
>>> "insn" appears to be an in-code abbreviation and should not appear in manual/help pages.
>>> ---
>> Thanks; sign-off?
> Oops, sorry.
>
> Signed-off-by: Matthias Krüger <matthias.krueger@famsik.de>
>
> (Is this sufficient or do I have to re-send the patch with the
> sign-off line?)

I can squash it in, so there is no need to resend. The more important thing is I won't have to for your future patches.

Thanks.