{"thread":{"id":"33313","subject":"[PATCH] git help config: s/insn/instruction/","startedAt":"2013-03-27T22:53:50Z","lastAt":"2013-03-28T15:55:14Z","messageCount":4,"participants":["Matthias Krüger","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"212484","messageId":"1364424830-17108-1-git-send-email-matthias.krueger@famsik.de","threadId":"33313","inReplyTo":null,"subject":"[PATCH] git help config: s/insn/instruction/","fromName":"Matthias Krüger","fromEmail":"matthias.krueger@famsik.de","sentAt":"2013-03-27T22:53:50Z","receivedAt":"2013-03-27T22:53:50Z","isPatch":true,"sender":{"key":"matthias.krueger@famsik.de","avatar":"https://avatars.githubusercontent.com/u/476013?v=4"},"body":"\"insn\" appears to be an in-code abbreviation and should not appear in manual/help pages.\n---\n Documentation/config.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/config.txt b/Documentation/config.txt\nindex c1f435f..f79184c 100644\n--- a/Documentation/config.txt\n+++ b/Documentation/config.txt\n@@ -555,7 +555,7 @@ core.commentchar::\n \t(default '#').\n \n sequence.editor::\n-\tText editor used by `git rebase -i` for editing the rebase insn file.\n+\tText editor used by `git rebase -i` for editing the rebase instruction file.\n \tThe value is meant to be interpreted by the shell when it is used.\n \tIt can be overridden by the `GIT_SEQUENCE_EDITOR` environment variable.\n \tWhen not configured the default commit message editor is used instead.\n-- \n1.8.2\n"},{"id":"212490","messageId":"7vboa4jc9a.fsf@alter.siamese.dyndns.org","threadId":"33313","inReplyTo":"1364424830-17108-1-git-send-email-matthias.krueger@famsik.de","subject":"Re: [PATCH] git help config: s/insn/instruction/","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-03-28T05:59:13Z","receivedAt":"2013-03-28T05:59:13Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Matthias Krüger writes:\n\n> \"insn\" appears to be an in-code abbreviation and should not appear in manual/help pages.\n> ---\n\nThanks; sign-off?\n"},{"id":"212494","messageId":"5153FEFD.3020703@famsik.de","threadId":"33313","inReplyTo":"7vboa4jc9a.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] git help config: s/insn/instruction/","fromName":"Matthias Krüger","fromEmail":"matthias.krueger@famsik.de","sentAt":"2013-03-28T08:27:41Z","receivedAt":"2013-03-28T08:27:41Z","isPatch":true,"sender":{"key":"matthias.krueger@famsik.de","avatar":"https://avatars.githubusercontent.com/u/476013?v=4"},"body":"On 03/28/2013 06:59 AM, Junio C Hamano wrote:\n> Matthias Krüger writes:\n>\n>> \"insn\" appears to be an in-code abbreviation and should not appear in manual/help pages.\n>> ---\n> Thanks; sign-off?\nOops, sorry.\n\nSigned-off-by: Matthias Krüger \n\n(Is this sufficient or do I have to re-send the patch with the sign-off \nline?)\n"},{"id":"212536","messageId":"7v7gkrwmcd.fsf@alter.siamese.dyndns.org","threadId":"33313","inReplyTo":"5153FEFD.3020703@famsik.de","subject":"Re: [PATCH] git help config: s/insn/instruction/","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-03-28T15:55:14Z","receivedAt":"2013-03-28T15:55:14Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Matthias Krüger writes:\n\n> On 03/28/2013 06:59 AM, Junio C Hamano wrote:\n>> Matthias Krüger writes:\n>>\n>>> \"insn\" appears to be an in-code abbreviation and should not appear in manual/help pages.\n>>> ---\n>> Thanks; sign-off?\n> Oops, sorry.\n>\n> Signed-off-by: Matthias Krüger \n>\n> (Is this sufficient or do I have to re-send the patch with the\n> sign-off line?)\n\nI can squash it in, so there is no need to resend. The more\nimportant thing is I won't have to for your future patches.\n\nThanks.\n"}]}