# [PATCH] git help config: s/insn/instruction/ 4 messages from 2013-03-27 to 2013-03-28. Participants: Matthias Krüger, Junio C Hamano. Thread: https://gitlist.dev/t/33313 ## Matthias Krüger, 2013-03-27 22:53 Subject: [PATCH] git help config: s/insn/instruction/ Message-ID: <1364424830-17108-1-git-send-email-matthias.krueger@famsik.de> URL: https://gitlist.dev/e/1364424830-17108-1-git-send-email-matthias.krueger%40famsik.de ``` "insn" appears to be an in-code abbreviation and should not appear in manual/help pages. --- Documentation/config.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/config.txt b/Documentation/config.txt index c1f435f..f79184c 100644 --- a/Documentation/config.txt +++ b/Documentation/config.txt @@ -555,7 +555,7 @@ core.commentchar:: (default '#'). sequence.editor:: - Text editor used by `git rebase -i` for editing the rebase insn file. + Text editor used by `git rebase -i` for editing the rebase instruction file. The value is meant to be interpreted by the shell when it is used. It can be overridden by the `GIT_SEQUENCE_EDITOR` environment variable. When not configured the default commit message editor is used instead. -- 1.8.2 ``` ## Junio C Hamano, 2013-03-28 05:59 Subject: Re: [PATCH] git help config: s/insn/instruction/ Message-ID: <7vboa4jc9a.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vboa4jc9a.fsf%40alter.siamese.dyndns.org In-Reply-To: <1364424830-17108-1-git-send-email-matthias.krueger@famsik.de> ``` Matthias Krüger writes: > "insn" appears to be an in-code abbreviation and should not appear in manual/help pages. > --- Thanks; sign-off? ``` ## Matthias Krüger, 2013-03-28 08:27 Subject: Re: [PATCH] git help config: s/insn/instruction/ Message-ID: <5153FEFD.3020703@famsik.de> URL: https://gitlist.dev/e/5153FEFD.3020703%40famsik.de In-Reply-To: <7vboa4jc9a.fsf@alter.siamese.dyndns.org> ``` On 03/28/2013 06:59 AM, Junio C Hamano wrote: > Matthias Krüger writes: > >> "insn" appears to be an in-code abbreviation and should not appear in manual/help pages. >> --- > Thanks; sign-off? Oops, sorry. Signed-off-by: Matthias Krüger (Is this sufficient or do I have to re-send the patch with the sign-off line?) ``` ## Junio C Hamano, 2013-03-28 15:55 Subject: Re: [PATCH] git help config: s/insn/instruction/ Message-ID: <7v7gkrwmcd.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7v7gkrwmcd.fsf%40alter.siamese.dyndns.org In-Reply-To: <5153FEFD.3020703@famsik.de> ``` Matthias Krüger writes: > On 03/28/2013 06:59 AM, Junio C Hamano wrote: >> Matthias Krüger writes: >> >>> "insn" appears to be an in-code abbreviation and should not appear in manual/help pages. >>> --- >> Thanks; sign-off? > Oops, sorry. > > Signed-off-by: Matthias Krüger > > (Is this sufficient or do I have to re-send the patch with the > sign-off line?) I can squash it in, so there is no need to resend. The more important thing is I won't have to for your future patches. Thanks. ```