threads / discuss / 33096

Re: git-scm.com/book/ru -- incorrect "next" link containing a question mark

Subject: Re: git-scm.com/book/ru -- incorrect "next" link containing a question mark

## tl;dr

2 messages between Mar 7, 2013 and Mar 8, 2013.

replies: 1people: 2as markdown or json

Konstantin Khomoutov· Mar 7, 2013, 08:47 UTC · lore

On Thu, 7 Mar 2013 00:01:31 -0800 (PST) Aleksey Rozhkov <ekkertan@gmail.com> wrote:

Show 5 quoted lines
> The page http://git-scm.com/book/ru/
> Введение-Первоначальная-настройка-Git contains incorrect link "next"
> Now this link to the page 
> http://git-scm.com/book/ru/Введение-Как-получить-помощь? , but this
> page does not exist
I would say "?" is just interpreted as a request part of the URL.
Indeed, the page source contains:

<a href="/book/ru/Введение-Установка-Git">prev</a> | <a href="/book/ru/Введение-Как-получить-помощь?">next</a>

so the question mark is really included verbatim.
> So, correct link is 
> http://git-scm.com/book/ru/Введение-Как-получить-помощь%3F

Good point, thanks. I Cc'ed the main Git list and made the message title a bit more clear.

To the Pro Git book maintainer: is it possible to somehow fix the HTML generation script to URL-encode any special characters if they're to appear in an URL?

Jeff King· Mar 8, 2013, 10:40 UTC · re: Konstantin Khomoutov · lore
On Thu, Mar 07, 2013 at 12:47:36PM +0400, Konstantin Khomoutov wrote:
Show 10 quoted lines
> On Thu, 7 Mar 2013 00:01:31 -0800 (PST)
> Aleksey Rozhkov <ekkertan@gmail.com> wrote:
> 
> > The page http://git-scm.com/book/ru/
> > Введение-Первоначальная-настройка-Git contains incorrect link "next"
> > Now this link to the page 
> > http://git-scm.com/book/ru/Введение-Как-получить-помощь? , but this
> > page does not exist
> 
> I would say "?" is just interpreted as a request part of the URL.

Yes, the problem is that the page's URL actually has the "?" in it, but it needs to be URL-encoded in links.

Show 5 quoted lines
> > So, correct link is 
> > http://git-scm.com/book/ru/Введение-Как-получить-помощь%3F
> 
> Good point, thanks.  I Cc'ed the main Git list and made the message
> title a bit more clear.

Exactly. I fixed a few instances of this a while ago, but not the prev/next pointers. This PR should fix all sites:

  https://github.com/github/gitscm-next/pull/259
> To the Pro Git book maintainer: is it possible to somehow fix the HTML
> generation script to URL-encode any special characters if they're to
> appear in an URL?

I don't think Scott reads the list too closely these days. In general, the best place to report git-scm.com problems is as an issue in the repo linked above.

-Peff

← back to recent threads