{"thread":{"id":"33096","subject":"Re: git-scm.com/book/ru -- incorrect \"next\" link containing a question mark","startedAt":"2013-03-07T08:47:36Z","lastAt":"2013-03-08T10:40:20Z","messageCount":2,"participants":["Konstantin Khomoutov","Jeff King"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"210751","messageId":"20130307124736.3d738c5aab39345fa9ca2930@domain007.com","threadId":"33096","inReplyTo":"5fe58162-33ed-48c2-a095-e98a355ed4f6@googlegroups.com","subject":"Re: git-scm.com/book/ru -- incorrect \"next\" link containing a question mark","fromName":"Konstantin Khomoutov","fromEmail":"kostix+git@007spb.ru","sentAt":"2013-03-07T08:47:36Z","receivedAt":"2013-03-07T08:47:36Z","isPatch":false,"sender":{"key":"kostix+git@007spb.ru","avatar":null},"body":"On Thu, 7 Mar 2013 00:01:31 -0800 (PST)\nAleksey Rozhkov <ekkertan@gmail.com> wrote:\n\n> The page http://git-scm.com/book/ru/\n> Введение-Первоначальная-настройка-Git contains incorrect link \"next\"\n> Now this link to the page \n> http://git-scm.com/book/ru/Введение-Как-получить-помощь? , but this\n> page does not exist\n\nI would say \"?\" is just interpreted as a request part of the URL.\n\nIndeed, the page source contains:\n\n<a href=\"/book/ru/Введение-Установка-Git\">prev</a> | <a\nhref=\"/book/ru/Введение-Как-получить-помощь?\">next</a>\n\nso the question mark is really included verbatim.\n\n> So, correct link is \n> http://git-scm.com/book/ru/Введение-Как-получить-помощь%3F\n\nGood point, thanks.  I Cc'ed the main Git list and made the message\ntitle a bit more clear.\n\nTo the Pro Git book maintainer: is it possible to somehow fix the HTML\ngeneration script to URL-encode any special characters if they're to\nappear in an URL?\n"},{"id":"210828","messageId":"20130308104019.GA16068@sigill.intra.peff.net","threadId":"33096","inReplyTo":"20130307124736.3d738c5aab39345fa9ca2930@domain007.com","subject":"Re: git-scm.com/book/ru -- incorrect \"next\" link containing a question mark","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2013-03-08T10:40:20Z","receivedAt":"2013-03-08T10:40:20Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Thu, Mar 07, 2013 at 12:47:36PM +0400, Konstantin Khomoutov wrote:\n\n> On Thu, 7 Mar 2013 00:01:31 -0800 (PST)\n> Aleksey Rozhkov <ekkertan@gmail.com> wrote:\n> \n> > The page http://git-scm.com/book/ru/\n> > Введение-Первоначальная-настройка-Git contains incorrect link \"next\"\n> > Now this link to the page \n> > http://git-scm.com/book/ru/Введение-Как-получить-помощь? , but this\n> > page does not exist\n> \n> I would say \"?\" is just interpreted as a request part of the URL.\n\nYes, the problem is that the page's URL actually has the \"?\" in it,\nbut it needs to be URL-encoded in links.\n\n> > So, correct link is \n> > http://git-scm.com/book/ru/Введение-Как-получить-помощь%3F\n> \n> Good point, thanks.  I Cc'ed the main Git list and made the message\n> title a bit more clear.\n\nExactly. I fixed a few instances of this a while ago, but not the\nprev/next pointers. This PR should fix all sites:\n\n  https://github.com/github/gitscm-next/pull/259\n\n> To the Pro Git book maintainer: is it possible to somehow fix the HTML\n> generation script to URL-encode any special characters if they're to\n> appear in an URL?\n\nI don't think Scott reads the list too closely these days. In general,\nthe best place to report git-scm.com problems is as an issue in the repo\nlinked above.\n\n-Peff\n"}]}