Re: git-scm.com/book/ru -- incorrect "next" link containing a question mark

From: Jeff King <peff@peff.net>
Date: Mar 8, 2013, 10:40 UTC
Message-ID: <20130308104019.GA16068@sigill.intra.peff.net>
In-Reply-To: <20130307124736.3d738c5aab39345fa9ca2930@domain007.com>

On Thu, Mar 07, 2013 at 12:47:36PM +0400, Konstantin Khomoutov wrote:

Show 10 quoted lines

> On Thu, 7 Mar 2013 00:01:31 -0800 (PST)
> Aleksey Rozhkov <ekkertan@gmail.com> wrote:
> 
> > The page http://git-scm.com/book/ru/
> > Введение-Первоначальная-настройка-Git contains incorrect link "next"
> > Now this link to the page 
> > http://git-scm.com/book/ru/Введение-Как-получить-помощь? , but this
> > page does not exist
> 
> I would say "?" is just interpreted as a request part of the URL.

Yes, the problem is that the page's URL actually has the "?" in it, but it needs to be URL-encoded in links.

Show 5 quoted lines

> > So, correct link is 
> > http://git-scm.com/book/ru/Введение-Как-получить-помощь%3F
> 
> Good point, thanks.  I Cc'ed the main Git list and made the message
> title a bit more clear.

Exactly. I fixed a few instances of this a while ago, but not the prev/next pointers. This PR should fix all sites:

  https://github.com/github/gitscm-next/pull/259

> To the Pro Git book maintainer: is it possible to somehow fix the HTML
> generation script to URL-encode any special characters if they're to
> appear in an URL?

I don't think Scott reads the list too closely these days. In general, the best place to report git-scm.com problems is as an issue in the repo linked above.

-Peff