threads / patch / 32532

patchfix compilation with NO_PTHREADS

Subject: [PATCH] fix compilation with NO_PTHREADS

## tl;dr

2 messages between Jan 5, 2013 and Jan 5, 2013. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Jeff King· Jan 5, 2013, 14:52 UTC · lore

Commit 1327452 cleaned up an unused parameter from wait_or_whine, but forgot to update a caller that is inside "#ifdef NO_PTHREADS".

Signed-off-by: Jeff King <peff@peff.net>
---
I happened to notice this while looking at the sigpipe topic. I guess
not many people are building with NO_PTHREADS these days.
 run-command.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to run-command.c +1 −1
diff --git a/run-command.c b/run-command.c
index cfb7274..0471219 100644
--- a/run-command.c
+++ b/run-command.c
@@ -725,7 +725,7 @@ int finish_async(struct async *async)
 int finish_async(struct async *async)
 {
 #ifdef NO_PTHREADS
-	return wait_or_whine(async->pid, "child process", 0);
+	return wait_or_whine(async->pid, "child process");
 #else
 	void *ret = (void *)(intptr_t)(-1);
 
-- 
1.8.1.rc1.16.g6d46841
Jonathan Nieder· Jan 5, 2013, 23:40 UTC · re: Jeff King · lore

Re: [PATCH] fix compilation with NO_PTHREADS

Jeff King wrote:
> I happened to notice this while looking at the sigpipe topic. I guess
> not many people are building with NO_PTHREADS these days.
Or that those people don't build "next". :)
Thanks for catching it.

← back to recent threads