git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] fix compilation with NO_PTHREADS

From
Jeff King <peff@peff.net>
Date
Jan 5, 2013, 14:52 UTC
Message-ID
<20130105145229.GA25112@sigill.intra.peff.net>

Commit 1327452 cleaned up an unused parameter from wait_or_whine, but forgot to update a caller that is inside "#ifdef NO_PTHREADS".

Signed-off-by: Jeff King <peff@peff.net>
---
I happened to notice this while looking at the sigpipe topic. I guess
not many people are building with NO_PTHREADS these days.
 run-command.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/run-command.c b/run-command.c
index cfb7274..0471219 100644
--- a/run-command.c
+++ b/run-command.c
@@ -725,7 +725,7 @@ int finish_async(struct async *async)
 int finish_async(struct async *async)
 {
 #ifdef NO_PTHREADS
-	return wait_or_whine(async->pid, "child process", 0);
+	return wait_or_whine(async->pid, "child process");
 #else
 	void *ret = (void *)(intptr_t)(-1);
 
-- 
1.8.1.rc1.16.g6d46841
Next: Jonathan Nieder
Message 1 of 2 in “fix compilation with NO_PTHREADS”
  1. fix compilation with NO_PTHREADSJeff King, Jan 5, 2013
  2. Jonathan NiederJan 5, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.