{"thread":{"id":"32532","subject":"[PATCH] fix compilation with NO_PTHREADS","startedAt":"2013-01-05T14:52:29Z","lastAt":"2013-01-05T23:40:10Z","messageCount":2,"participants":["Jeff King","Jonathan Nieder"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"206030","messageId":"20130105145229.GA25112@sigill.intra.peff.net","threadId":"32532","inReplyTo":null,"subject":"[PATCH] fix compilation with NO_PTHREADS","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2013-01-05T14:52:29Z","receivedAt":"2013-01-05T14:52:29Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"Commit 1327452 cleaned up an unused parameter from\nwait_or_whine, but forgot to update a caller that is inside\n\"#ifdef NO_PTHREADS\".\n\nSigned-off-by: Jeff King <peff@peff.net>\n---\nI happened to notice this while looking at the sigpipe topic. I guess\nnot many people are building with NO_PTHREADS these days.\n\n run-command.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/run-command.c b/run-command.c\nindex cfb7274..0471219 100644\n--- a/run-command.c\n+++ b/run-command.c\n@@ -725,7 +725,7 @@ int finish_async(struct async *async)\n int finish_async(struct async *async)\n {\n #ifdef NO_PTHREADS\n-\treturn wait_or_whine(async->pid, \"child process\", 0);\n+\treturn wait_or_whine(async->pid, \"child process\");\n #else\n \tvoid *ret = (void *)(intptr_t)(-1);\n \n-- \n1.8.1.rc1.16.g6d46841\n"},{"id":"206075","messageId":"20130105234010.GB5686@elie.Belkin","threadId":"32532","inReplyTo":"20130105145229.GA25112@sigill.intra.peff.net","subject":"Re: [PATCH] fix compilation with NO_PTHREADS","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2013-01-05T23:40:10Z","receivedAt":"2013-01-05T23:40:10Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Jeff King wrote:\n\n> I happened to notice this while looking at the sigpipe topic. I guess\n> not many people are building with NO_PTHREADS these days.\n\nOr that those people don't build \"next\". :)\n\nThanks for catching it.\n"}]}