threads / bug / 32497

Bug in latest gitk - can't click lines connecting commits

Subject: Bug in latest gitk - can't click lines connecting commits

## tl;dr

6 messages between Jan 1, 2013 and Jan 23, 2013.

replies: 5people: 4as markdown or json

Jason Holden· Jan 1, 2013, 17:21 UTC · lore

I was testing some patches against the latest gitk, and noticed that when I 
click the mouse on the lines that connect the commits in the history graph,
I get an error popup with:
 Error: can't read "cflist_top": no such variable

Looks like this was introduced in gitk commit b967135d89e8d8461d059
 gitk: Synchronize highlighting in file view when scrolling diff

This commit hasn't been merged yet from upstream into git.

Here's the full error trace:
can't read "cflist_top": no such variable
can't read "cflist_top": no such variable
    while executing
"$cflist tag remove highlight $cflist_top.0 "$cflist_top.0 lineend""
    (procedure "highlightfile" line 4)
    invoked from within
"highlightfile 0"
    (procedure "highlightfile_for_scrollpos" line 8)
    invoked from within
"highlightfile_for_scrollpos $topidx"
    (procedure "scrolltext" line 9)
    invoked from within
"scrolltext 0.0 1.0"
    (vertical scrolling command executed by text)

-Jason

Stefan Haller· Jan 1, 2013, 17:54 UTC · re: Jason Holden · lore

Re: Bug in latest gitk - can't click lines connecting commits

Jason Holden <jason.k.holden.swdev@gmail.com> wrote:

Show 7 quoted lines

> I was testing some patches against the latest gitk, and noticed that when I
> click the mouse on the lines that connect the commits in the history graph,
> I get an error popup with:
>  Error: can't read "cflist_top": no such variable
> 
> Looks like this was introduced in gitk commit b967135d89e8d8461d059
>  gitk: Synchronize highlighting in file view when scrolling diff

A patch that fixes this was proposed over two months ago, and Paul said he had applied it:

  <http://permalink.gmane.org/gmane.comp.version-control.git/208162>

However, looking at git://ozlabs.org/~paulus/gitk.git it's not there. Paul?

-- 
Stefan Haller
Berlin, Germany
http://www.haller-berlin.de/

Paul Mackerras· Jan 1, 2013, 23:22 UTC · re: Stefan Haller · lore

Re: Bug in latest gitk - can't click lines connecting commits

On Tue, Jan 01, 2013 at 06:54:23PM +0100, Stefan Haller wrote:

Show 17 quoted lines

> Jason Holden <jason.k.holden.swdev@gmail.com> wrote:
> 
> > I was testing some patches against the latest gitk, and noticed that when I
> > click the mouse on the lines that connect the commits in the history graph,
> > I get an error popup with:
> >  Error: can't read "cflist_top": no such variable
> > 
> > Looks like this was introduced in gitk commit b967135d89e8d8461d059
> >  gitk: Synchronize highlighting in file view when scrolling diff
> 
> A patch that fixes this was proposed over two months ago, and Paul said
> he had applied it:
> 
>   <http://permalink.gmane.org/gmane.comp.version-control.git/208162>
> 
> However, looking at git://ozlabs.org/~paulus/gitk.git it's not there.
> Paul?

I just forgot to push it out.  It's there now.

Paul.

Junio C Hamano· Jan 22, 2013, 17:28 UTC · re: Paul Mackerras · lore

Re: Bug in latest gitk - can't click lines connecting commits

Paul Mackerras <paulus@samba.org> writes:

Show 20 quoted lines

> On Tue, Jan 01, 2013 at 06:54:23PM +0100, Stefan Haller wrote:
>> Jason Holden <jason.k.holden.swdev@gmail.com> wrote:
>> 
>> > I was testing some patches against the latest gitk, and noticed that when I
>> > click the mouse on the lines that connect the commits in the history graph,
>> > I get an error popup with:
>> >  Error: can't read "cflist_top": no such variable
>> > 
>> > Looks like this was introduced in gitk commit b967135d89e8d8461d059
>> >  gitk: Synchronize highlighting in file view when scrolling diff
>> 
>> A patch that fixes this was proposed over two months ago, and Paul said
>> he had applied it:
>> 
>>   <http://permalink.gmane.org/gmane.comp.version-control.git/208162>
>> 
>> However, looking at git://ozlabs.org/~paulus/gitk.git it's not there.
>> Paul?
>
> I just forgot to push it out.  It's there now.

I notice that I have a handful of commits that I haven't pulled from your repository, and the last commit on your 'master' is about 20 days old. Is it safe for me to pull these now?

I can teach myself that your push is your pull-request, but I do not think we agreed to arrange it that way yet, so...

Paul Mackerras· Jan 23, 2013, 11:48 UTC · re: Junio C Hamano · lore

Re: Bug in latest gitk - can't click lines connecting commits

On Tue, Jan 22, 2013 at 09:28:23AM -0800, Junio C Hamano wrote:

> 
> I notice that I have a handful of commits that I haven't pulled from
> your repository, and the last commit on your 'master' is about 20
> days old.  Is it safe for me to pull these now?

Yes, please pull them now.

Regards, Paul.

Junio C Hamano· Jan 23, 2013, 16:35 UTC · re: Paul Mackerras · lore

Re: Bug in latest gitk - can't click lines connecting commits

Paul Mackerras <paulus@samba.org> writes:

Show 7 quoted lines

> On Tue, Jan 22, 2013 at 09:28:23AM -0800, Junio C Hamano wrote:
>> 
>> I notice that I have a handful of commits that I haven't pulled from
>> your repository, and the last commit on your 'master' is about 20
>> days old.  Is it safe for me to pull these now?
>
> Yes, please pull them now.

Thanks.