# Bug in latest gitk - can't click lines connecting commits 6 messages from 2013-01-01 to 2013-01-23. Participants: Jason Holden, Stefan Haller, Paul Mackerras, Junio C Hamano. Thread: https://gitlist.dev/t/32497 ## Jason Holden, 2013-01-01 17:21 Subject: Bug in latest gitk - can't click lines connecting commits Message-ID: <20130101172156.GA22450@gmail.com> URL: https://gitlist.dev/e/20130101172156.GA22450%40gmail.com ``` I was testing some patches against the latest gitk, and noticed that when I click the mouse on the lines that connect the commits in the history graph, I get an error popup with: Error: can't read "cflist_top": no such variable Looks like this was introduced in gitk commit b967135d89e8d8461d059 gitk: Synchronize highlighting in file view when scrolling diff This commit hasn't been merged yet from upstream into git. Here's the full error trace: can't read "cflist_top": no such variable can't read "cflist_top": no such variable while executing "$cflist tag remove highlight $cflist_top.0 "$cflist_top.0 lineend"" (procedure "highlightfile" line 4) invoked from within "highlightfile 0" (procedure "highlightfile_for_scrollpos" line 8) invoked from within "highlightfile_for_scrollpos $topidx" (procedure "scrolltext" line 9) invoked from within "scrolltext 0.0 1.0" (vertical scrolling command executed by text) -Jason ``` ## Stefan Haller, 2013-01-01 17:54 Subject: Re: Bug in latest gitk - can't click lines connecting commits Message-ID: <1kw18d3.5sftkl125qdz4M%stefan@haller-berlin.de> URL: https://gitlist.dev/e/1kw18d3.5sftkl125qdz4M%25stefan%40haller-berlin.de In-Reply-To: <20130101172156.GA22450@gmail.com> ``` Jason Holden wrote: > I was testing some patches against the latest gitk, and noticed that when I > click the mouse on the lines that connect the commits in the history graph, > I get an error popup with: > Error: can't read "cflist_top": no such variable > > Looks like this was introduced in gitk commit b967135d89e8d8461d059 > gitk: Synchronize highlighting in file view when scrolling diff A patch that fixes this was proposed over two months ago, and Paul said he had applied it: However, looking at git://ozlabs.org/~paulus/gitk.git it's not there. Paul? -- Stefan Haller Berlin, Germany http://www.haller-berlin.de/ ``` ## Paul Mackerras, 2013-01-01 23:22 Subject: Re: Bug in latest gitk - can't click lines connecting commits Message-ID: <20130101232220.GD20724@iris.ozlabs.ibm.com> URL: https://gitlist.dev/e/20130101232220.GD20724%40iris.ozlabs.ibm.com In-Reply-To: <1kw18d3.5sftkl125qdz4M%stefan@haller-berlin.de> ``` On Tue, Jan 01, 2013 at 06:54:23PM +0100, Stefan Haller wrote: > Jason Holden wrote: > > > I was testing some patches against the latest gitk, and noticed that when I > > click the mouse on the lines that connect the commits in the history graph, > > I get an error popup with: > > Error: can't read "cflist_top": no such variable > > > > Looks like this was introduced in gitk commit b967135d89e8d8461d059 > > gitk: Synchronize highlighting in file view when scrolling diff > > A patch that fixes this was proposed over two months ago, and Paul said > he had applied it: > > > > However, looking at git://ozlabs.org/~paulus/gitk.git it's not there. > Paul? I just forgot to push it out. It's there now. Paul. ``` ## Junio C Hamano, 2013-01-22 17:28 Subject: Re: Bug in latest gitk - can't click lines connecting commits Message-ID: <7v622p9lfs.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7v622p9lfs.fsf%40alter.siamese.dyndns.org In-Reply-To: <20130101232220.GD20724@iris.ozlabs.ibm.com> ``` Paul Mackerras writes: > On Tue, Jan 01, 2013 at 06:54:23PM +0100, Stefan Haller wrote: >> Jason Holden wrote: >> >> > I was testing some patches against the latest gitk, and noticed that when I >> > click the mouse on the lines that connect the commits in the history graph, >> > I get an error popup with: >> > Error: can't read "cflist_top": no such variable >> > >> > Looks like this was introduced in gitk commit b967135d89e8d8461d059 >> > gitk: Synchronize highlighting in file view when scrolling diff >> >> A patch that fixes this was proposed over two months ago, and Paul said >> he had applied it: >> >> >> >> However, looking at git://ozlabs.org/~paulus/gitk.git it's not there. >> Paul? > > I just forgot to push it out. It's there now. I notice that I have a handful of commits that I haven't pulled from your repository, and the last commit on your 'master' is about 20 days old. Is it safe for me to pull these now? I can teach myself that your push is your pull-request, but I do not think we agreed to arrange it that way yet, so... ``` ## Paul Mackerras, 2013-01-23 11:48 Subject: Re: Bug in latest gitk - can't click lines connecting commits Message-ID: <20130123114806.GA21124@iris.ozlabs.ibm.com> URL: https://gitlist.dev/e/20130123114806.GA21124%40iris.ozlabs.ibm.com In-Reply-To: <7v622p9lfs.fsf@alter.siamese.dyndns.org> ``` On Tue, Jan 22, 2013 at 09:28:23AM -0800, Junio C Hamano wrote: > > I notice that I have a handful of commits that I haven't pulled from > your repository, and the last commit on your 'master' is about 20 > days old. Is it safe for me to pull these now? Yes, please pull them now. Regards, Paul. ``` ## Junio C Hamano, 2013-01-23 16:35 Subject: Re: Bug in latest gitk - can't click lines connecting commits Message-ID: <7vehhbj1qs.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vehhbj1qs.fsf%40alter.siamese.dyndns.org In-Reply-To: <20130123114806.GA21124@iris.ozlabs.ibm.com> ``` Paul Mackerras writes: > On Tue, Jan 22, 2013 at 09:28:23AM -0800, Junio C Hamano wrote: >> >> I notice that I have a handful of commits that I haven't pulled from >> your repository, and the last commit on your 'master' is about 20 >> days old. Is it safe for me to pull these now? > > Yes, please pull them now. Thanks. ```