{"thread":{"id":"32497","subject":"Bug in latest gitk - can't click lines connecting commits","startedAt":"2013-01-01T17:21:57Z","lastAt":"2013-01-23T16:35:55Z","messageCount":6,"participants":["Jason Holden","Stefan Haller","Paul Mackerras","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"205771","messageId":"20130101172156.GA22450@gmail.com","threadId":"32497","inReplyTo":null,"subject":"Bug in latest gitk - can't click lines connecting commits","fromName":"Jason Holden","fromEmail":"jason.k.holden.swdev@gmail.com","sentAt":"2013-01-01T17:21:57Z","receivedAt":"2013-01-01T17:21:57Z","isPatch":false,"sender":{"key":"jason.k.holden.swdev@gmail.com","avatar":null},"body":"I was testing some patches against the latest gitk, and noticed that when I \nclick the mouse on the lines that connect the commits in the history graph,\nI get an error popup with:\n Error: can't read \"cflist_top\": no such variable\n\nLooks like this was introduced in gitk commit b967135d89e8d8461d059\n gitk: Synchronize highlighting in file view when scrolling diff\n\nThis commit hasn't been merged yet from upstream into git.\n\nHere's the full error trace:\ncan't read \"cflist_top\": no such variable\ncan't read \"cflist_top\": no such variable\n while executing\n\"$cflist tag remove highlight $cflist_top.0 \"$cflist_top.0 lineend\"\"\n (procedure \"highlightfile\" line 4)\n invoked from within\n\"highlightfile 0\"\n (procedure \"highlightfile_for_scrollpos\" line 8)\n invoked from within\n\"highlightfile_for_scrollpos $topidx\"\n (procedure \"scrolltext\" line 9)\n invoked from within\n\"scrolltext 0.0 1.0\"\n (vertical scrolling command executed by text)\n\n-Jason\n"},{"id":"205773","messageId":"1kw18d3.5sftkl125qdz4M%stefan@haller-berlin.de","threadId":"32497","inReplyTo":"20130101172156.GA22450@gmail.com","subject":"Re: Bug in latest gitk - can't click lines connecting commits","fromName":"Stefan Haller","fromEmail":"stefan@haller-berlin.de","sentAt":"2013-01-01T17:54:23Z","receivedAt":"2013-01-01T17:54:23Z","isPatch":false,"sender":{"key":"stefan@haller-berlin.de","avatar":"https://avatars.githubusercontent.com/u/1225667?v=4"},"body":"Jason Holden wrote:\n\n> I was testing some patches against the latest gitk, and noticed that when I\n> click the mouse on the lines that connect the commits in the history graph,\n> I get an error popup with:\n> Error: can't read \"cflist_top\": no such variable\n> \n> Looks like this was introduced in gitk commit b967135d89e8d8461d059\n> gitk: Synchronize highlighting in file view when scrolling diff\n\nA patch that fixes this was proposed over two months ago, and Paul said\nhe had applied it:\n\n \n\nHowever, looking at git://ozlabs.org/~paulus/gitk.git it's not there.\nPaul?\n\n\n-- \nStefan Haller\nBerlin, Germany\nhttp://www.haller-berlin.de/\n"},{"id":"205824","messageId":"20130101232220.GD20724@iris.ozlabs.ibm.com","threadId":"32497","inReplyTo":"1kw18d3.5sftkl125qdz4M%stefan@haller-berlin.de","subject":"Re: Bug in latest gitk - can't click lines connecting commits","fromName":"Paul Mackerras","fromEmail":"paulus@samba.org","sentAt":"2013-01-01T23:22:20Z","receivedAt":"2013-01-01T23:22:20Z","isPatch":false,"sender":{"key":"paulus@samba.org","avatar":"https://avatars.githubusercontent.com/u/1606439?v=4"},"body":"On Tue, Jan 01, 2013 at 06:54:23PM +0100, Stefan Haller wrote:\n> Jason Holden wrote:\n> \n> > I was testing some patches against the latest gitk, and noticed that when I\n> > click the mouse on the lines that connect the commits in the history graph,\n> > I get an error popup with:\n> > Error: can't read \"cflist_top\": no such variable\n> > \n> > Looks like this was introduced in gitk commit b967135d89e8d8461d059\n> > gitk: Synchronize highlighting in file view when scrolling diff\n> \n> A patch that fixes this was proposed over two months ago, and Paul said\n> he had applied it:\n> \n> \n> \n> However, looking at git://ozlabs.org/~paulus/gitk.git it's not there.\n> Paul?\n\nI just forgot to push it out. It's there now.\n\nPaul.\n"},{"id":"207516","messageId":"7v622p9lfs.fsf@alter.siamese.dyndns.org","threadId":"32497","inReplyTo":"20130101232220.GD20724@iris.ozlabs.ibm.com","subject":"Re: Bug in latest gitk - can't click lines connecting commits","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-01-22T17:28:23Z","receivedAt":"2013-01-22T17:28:23Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Paul Mackerras writes:\n\n> On Tue, Jan 01, 2013 at 06:54:23PM +0100, Stefan Haller wrote:\n>> Jason Holden wrote:\n>> \n>> > I was testing some patches against the latest gitk, and noticed that when I\n>> > click the mouse on the lines that connect the commits in the history graph,\n>> > I get an error popup with:\n>> > Error: can't read \"cflist_top\": no such variable\n>> > \n>> > Looks like this was introduced in gitk commit b967135d89e8d8461d059\n>> > gitk: Synchronize highlighting in file view when scrolling diff\n>> \n>> A patch that fixes this was proposed over two months ago, and Paul said\n>> he had applied it:\n>> \n>> \n>> \n>> However, looking at git://ozlabs.org/~paulus/gitk.git it's not there.\n>> Paul?\n>\n> I just forgot to push it out. It's there now.\n\nI notice that I have a handful of commits that I haven't pulled from\nyour repository, and the last commit on your 'master' is about 20\ndays old. Is it safe for me to pull these now?\n\nI can teach myself that your push is your pull-request, but I do not\nthink we agreed to arrange it that way yet, so...\n"},{"id":"207585","messageId":"20130123114806.GA21124@iris.ozlabs.ibm.com","threadId":"32497","inReplyTo":"7v622p9lfs.fsf@alter.siamese.dyndns.org","subject":"Re: Bug in latest gitk - can't click lines connecting commits","fromName":"Paul Mackerras","fromEmail":"paulus@samba.org","sentAt":"2013-01-23T11:48:06Z","receivedAt":"2013-01-23T11:48:06Z","isPatch":false,"sender":{"key":"paulus@samba.org","avatar":"https://avatars.githubusercontent.com/u/1606439?v=4"},"body":"On Tue, Jan 22, 2013 at 09:28:23AM -0800, Junio C Hamano wrote:\n> \n> I notice that I have a handful of commits that I haven't pulled from\n> your repository, and the last commit on your 'master' is about 20\n> days old. Is it safe for me to pull these now?\n\nYes, please pull them now.\n\nRegards,\nPaul.\n"},{"id":"207606","messageId":"7vehhbj1qs.fsf@alter.siamese.dyndns.org","threadId":"32497","inReplyTo":"20130123114806.GA21124@iris.ozlabs.ibm.com","subject":"Re: Bug in latest gitk - can't click lines connecting commits","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-01-23T16:35:55Z","receivedAt":"2013-01-23T16:35:55Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Paul Mackerras writes:\n\n> On Tue, Jan 22, 2013 at 09:28:23AM -0800, Junio C Hamano wrote:\n>> \n>> I notice that I have a handful of commits that I haven't pulled from\n>> your repository, and the last commit on your 'master' is about 20\n>> days old. Is it safe for me to pull these now?\n>\n> Yes, please pull them now.\n\nThanks.\n"}]}