threads / patch / 32351

patcht3070: Disable some failing fnmatch tests

Subject: [PATCH] t3070: Disable some failing fnmatch tests

## tl;dr

3 messages between Dec 15, 2012 and Dec 17, 2012. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Ramsay Jones· Dec 15, 2012, 19:19 UTC · lore

The failing tests make use of a POSIX character class, '[:xdigit:]' in this case, which some versions of the fnmatch() library function do not support. In the spirit of commit f1cf7b79 ("t3070: disable unreliable fnmatch tests", 15-10-2012), we disable the fnmatch() half of these tests.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---

Hi Junio,

This is against next (branch 'nd/wildmatch'). As an alternative solution, I could build with NO_FNMATCH, since the compat version does support the POSIX charater classes.

ATB, Ramsay Jones

 t/t3070-wildmatch.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Show changes to t/t3070-wildmatch.sh +3 −3

diff --git a/t/t3070-wildmatch.sh b/t/t3070-wildmatch.sh
index 3155eab..d5bafef 100755
--- a/t/t3070-wildmatch.sh
+++ b/t/t3070-wildmatch.sh
@@ -120,9 +120,9 @@ match 0 x '1' '[[:digit:][:upper:][:spaci:]]'
 match 1 x ' ' '[[:digit:][:upper:][:space:]]'
 match 0 x '.' '[[:digit:][:upper:][:space:]]'
 match 1 x '.' '[[:digit:][:punct:][:space:]]'
-match 1 1 '5' '[[:xdigit:]]'
-match 1 1 'f' '[[:xdigit:]]'
-match 1 1 'D' '[[:xdigit:]]'
+match 1 x '5' '[[:xdigit:]]'
+match 1 x 'f' '[[:xdigit:]]'
+match 1 x 'D' '[[:xdigit:]]'
 match 1 x '_' '[[:alnum:][:alpha:][:blank:][:cntrl:][:digit:][:graph:][:lower:][:print:][:punct:][:space:][:upper:][:xdigit:]]'
 match 1 x '_' '[[:alnum:][:alpha:][:blank:][:cntrl:][:digit:][:graph:][:lower:][:print:][:punct:][:space:][:upper:][:xdigit:]]'
 match 1 x '.' '[^[:alnum:][:alpha:][:blank:][:cntrl:][:digit:][:lower:][:space:][:upper:][:xdigit:]]'

-- 
1.8.0

Nguyen Thai Ngoc Duy· Dec 16, 2012, 04:31 UTC · re: Ramsay Jones · lore

Re: [PATCH] t3070: Disable some failing fnmatch tests

On Sun, Dec 16, 2012 at 2:19 AM, Ramsay Jones <ramsay@ramsay1.demon.co.uk> wrote:

Show 6 quoted lines

>
> The failing tests make use of a POSIX character class, '[:xdigit:]'
> in this case, which some versions of the fnmatch() library function
> do not support. In the spirit of commit f1cf7b79 ("t3070: disable
> unreliable fnmatch tests", 15-10-2012), we disable the fnmatch() half
> of these tests.

I have no problem with this. You're on cygwin, right?

-- 
Duy

Ramsay Jones· Dec 17, 2012, 22:05 UTC · re: Nguyen Thai Ngoc Duy · lore

Re: [PATCH] t3070: Disable some failing fnmatch tests

Nguyen Thai Ngoc Duy wrote:

Show 10 quoted lines

> On Sun, Dec 16, 2012 at 2:19 AM, Ramsay Jones
> <ramsay@ramsay1.demon.co.uk> wrote:
>>
>> The failing tests make use of a POSIX character class, '[:xdigit:]'
>> in this case, which some versions of the fnmatch() library function
>> do not support. In the spirit of commit f1cf7b79 ("t3070: disable
>> unreliable fnmatch tests", 15-10-2012), we disable the fnmatch() half
>> of these tests.
> 
> I have no problem with this. You're on cygwin, right?

My main platform is Linux, but I also like to keep cygwin working. (... and I also build MinGW just for fun!)

Yes, it was cygwin that suffered these test failures. (MinGW is built with NO_FNMATCH=YesPlease.)

ATB, Ramsay Jones