{"thread":{"id":"32351","subject":"[PATCH] t3070: Disable some failing fnmatch tests","startedAt":"2012-12-15T19:19:18Z","lastAt":"2012-12-17T22:05:35Z","messageCount":3,"participants":["Ramsay Jones","Nguyen Thai Ngoc Duy"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"204938","messageId":"50CCCD36.9020001@ramsay1.demon.co.uk","threadId":"32351","inReplyTo":null,"subject":"[PATCH] t3070: Disable some failing fnmatch tests","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2012-12-15T19:19:18Z","receivedAt":"2012-12-15T19:19:18Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nThe failing tests make use of a POSIX character class, '[:xdigit:]'\nin this case, which some versions of the fnmatch() library function\ndo not support. In the spirit of commit f1cf7b79 (\"t3070: disable\nunreliable fnmatch tests\", 15-10-2012), we disable the fnmatch() half\nof these tests.\n\nSigned-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n---\n\nHi Junio,\n\nThis is against next (branch 'nd/wildmatch'). As an alternative solution,\nI could build with NO_FNMATCH, since the compat version does support the\nPOSIX charater classes.\n\nATB,\nRamsay Jones\n\n t/t3070-wildmatch.sh | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/t/t3070-wildmatch.sh b/t/t3070-wildmatch.sh\nindex 3155eab..d5bafef 100755\n--- a/t/t3070-wildmatch.sh\n+++ b/t/t3070-wildmatch.sh\n@@ -120,9 +120,9 @@ match 0 x '1' '[[:digit:][:upper:][:spaci:]]'\n match 1 x ' ' '[[:digit:][:upper:][:space:]]'\n match 0 x '.' '[[:digit:][:upper:][:space:]]'\n match 1 x '.' '[[:digit:][:punct:][:space:]]'\n-match 1 1 '5' '[[:xdigit:]]'\n-match 1 1 'f' '[[:xdigit:]]'\n-match 1 1 'D' '[[:xdigit:]]'\n+match 1 x '5' '[[:xdigit:]]'\n+match 1 x 'f' '[[:xdigit:]]'\n+match 1 x 'D' '[[:xdigit:]]'\n match 1 x '_' '[[:alnum:][:alpha:][:blank:][:cntrl:][:digit:][:graph:][:lower:][:print:][:punct:][:space:][:upper:][:xdigit:]]'\n match 1 x '_' '[[:alnum:][:alpha:][:blank:][:cntrl:][:digit:][:graph:][:lower:][:print:][:punct:][:space:][:upper:][:xdigit:]]'\n match 1 x '.' '[^[:alnum:][:alpha:][:blank:][:cntrl:][:digit:][:lower:][:space:][:upper:][:xdigit:]]'\n-- \n1.8.0\n"},{"id":"204955","messageId":"CACsJy8DOhZjm05KVQYaR+HbQAu=wDNR=+NZ7H_hG8P5ZsNzSKg@mail.gmail.com","threadId":"32351","inReplyTo":"50CCCD36.9020001@ramsay1.demon.co.uk","subject":"Re: [PATCH] t3070: Disable some failing fnmatch tests","fromName":"Nguyen Thai Ngoc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2012-12-16T04:31:59Z","receivedAt":"2012-12-16T04:31:59Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"On Sun, Dec 16, 2012 at 2:19 AM, Ramsay Jones\n<ramsay@ramsay1.demon.co.uk> wrote:\n>\n> The failing tests make use of a POSIX character class, '[:xdigit:]'\n> in this case, which some versions of the fnmatch() library function\n> do not support. In the spirit of commit f1cf7b79 (\"t3070: disable\n> unreliable fnmatch tests\", 15-10-2012), we disable the fnmatch() half\n> of these tests.\n\nI have no problem with this. You're on cygwin, right?\n-- \nDuy\n"},{"id":"205083","messageId":"50CF972F.9080907@ramsay1.demon.co.uk","threadId":"32351","inReplyTo":"CACsJy8DOhZjm05KVQYaR+HbQAu=wDNR=+NZ7H_hG8P5ZsNzSKg@mail.gmail.com","subject":"Re: [PATCH] t3070: Disable some failing fnmatch tests","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2012-12-17T22:05:35Z","receivedAt":"2012-12-17T22:05:35Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"Nguyen Thai Ngoc Duy wrote:\n> On Sun, Dec 16, 2012 at 2:19 AM, Ramsay Jones\n> <ramsay@ramsay1.demon.co.uk> wrote:\n>>\n>> The failing tests make use of a POSIX character class, '[:xdigit:]'\n>> in this case, which some versions of the fnmatch() library function\n>> do not support. In the spirit of commit f1cf7b79 (\"t3070: disable\n>> unreliable fnmatch tests\", 15-10-2012), we disable the fnmatch() half\n>> of these tests.\n> \n> I have no problem with this. You're on cygwin, right?\n\nMy main platform is Linux, but I also like to keep cygwin working.\n(... and I also build MinGW just for fun!)\n\nYes, it was cygwin that suffered these test failures. (MinGW is built\nwith NO_FNMATCH=YesPlease.)\n\nATB,\nRamsay Jones\n"}]}