# [PATCH] t3070: Disable some failing fnmatch tests 3 messages from 2012-12-15 to 2012-12-17. Participants: Ramsay Jones, Nguyen Thai Ngoc Duy. Thread: https://gitlist.dev/t/32351 ## Ramsay Jones, 2012-12-15 19:19 Subject: [PATCH] t3070: Disable some failing fnmatch tests Message-ID: <50CCCD36.9020001@ramsay1.demon.co.uk> URL: https://gitlist.dev/e/50CCCD36.9020001%40ramsay1.demon.co.uk ``` The failing tests make use of a POSIX character class, '[:xdigit:]' in this case, which some versions of the fnmatch() library function do not support. In the spirit of commit f1cf7b79 ("t3070: disable unreliable fnmatch tests", 15-10-2012), we disable the fnmatch() half of these tests. Signed-off-by: Ramsay Jones --- Hi Junio, This is against next (branch 'nd/wildmatch'). As an alternative solution, I could build with NO_FNMATCH, since the compat version does support the POSIX charater classes. ATB, Ramsay Jones t/t3070-wildmatch.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/t/t3070-wildmatch.sh b/t/t3070-wildmatch.sh index 3155eab..d5bafef 100755 --- a/t/t3070-wildmatch.sh +++ b/t/t3070-wildmatch.sh @@ -120,9 +120,9 @@ match 0 x '1' '[[:digit:][:upper:][:spaci:]]' match 1 x ' ' '[[:digit:][:upper:][:space:]]' match 0 x '.' '[[:digit:][:upper:][:space:]]' match 1 x '.' '[[:digit:][:punct:][:space:]]' -match 1 1 '5' '[[:xdigit:]]' -match 1 1 'f' '[[:xdigit:]]' -match 1 1 'D' '[[:xdigit:]]' +match 1 x '5' '[[:xdigit:]]' +match 1 x 'f' '[[:xdigit:]]' +match 1 x 'D' '[[:xdigit:]]' match 1 x '_' '[[:alnum:][:alpha:][:blank:][:cntrl:][:digit:][:graph:][:lower:][:print:][:punct:][:space:][:upper:][:xdigit:]]' match 1 x '_' '[[:alnum:][:alpha:][:blank:][:cntrl:][:digit:][:graph:][:lower:][:print:][:punct:][:space:][:upper:][:xdigit:]]' match 1 x '.' '[^[:alnum:][:alpha:][:blank:][:cntrl:][:digit:][:lower:][:space:][:upper:][:xdigit:]]' -- 1.8.0 ``` ## Nguyen Thai Ngoc Duy, 2012-12-16 04:31 Subject: Re: [PATCH] t3070: Disable some failing fnmatch tests Message-ID: URL: https://gitlist.dev/e/CACsJy8DOhZjm05KVQYaR%2BHbQAu%3DwDNR%3D%2BNZ7H_hG8P5ZsNzSKg%40mail.gmail.com In-Reply-To: <50CCCD36.9020001@ramsay1.demon.co.uk> ``` On Sun, Dec 16, 2012 at 2:19 AM, Ramsay Jones wrote: > > The failing tests make use of a POSIX character class, '[:xdigit:]' > in this case, which some versions of the fnmatch() library function > do not support. In the spirit of commit f1cf7b79 ("t3070: disable > unreliable fnmatch tests", 15-10-2012), we disable the fnmatch() half > of these tests. I have no problem with this. You're on cygwin, right? -- Duy ``` ## Ramsay Jones, 2012-12-17 22:05 Subject: Re: [PATCH] t3070: Disable some failing fnmatch tests Message-ID: <50CF972F.9080907@ramsay1.demon.co.uk> URL: https://gitlist.dev/e/50CF972F.9080907%40ramsay1.demon.co.uk In-Reply-To: ``` Nguyen Thai Ngoc Duy wrote: > On Sun, Dec 16, 2012 at 2:19 AM, Ramsay Jones > wrote: >> >> The failing tests make use of a POSIX character class, '[:xdigit:]' >> in this case, which some versions of the fnmatch() library function >> do not support. In the spirit of commit f1cf7b79 ("t3070: disable >> unreliable fnmatch tests", 15-10-2012), we disable the fnmatch() half >> of these tests. > > I have no problem with this. You're on cygwin, right? My main platform is Linux, but I also like to keep cygwin working. (... and I also build MinGW just for fun!) Yes, it was cygwin that suffered these test failures. (MinGW is built with NO_FNMATCH=YesPlease.) ATB, Ramsay Jones ```