threads / patch / 32342

patch, 4 partsDeclare that HP NonStop systems require strings.h

Subject: [PATCH 4/4] Declare that HP NonStop systems require strings.h

## tl;dr

4 messages between Dec 14, 2012 and Dec 14, 2012. Diffs are folded; open one to read it.

replies: 3people: 4as markdown or json

David Michael· Dec 14, 2012, 19:57 UTC · lore

This platform previously included strings.h automatically. However, the build system now requires an explicit option to do so.

Signed-off-by: David Michael <fedora.dm0@gmail.com>
---
 Makefile | 1 +
 1 file changed, 1 insertion(+)
Show changes to Makefile +1 −1
diff --git a/Makefile b/Makefile
index fb78f7f..e84b0cb 100644
--- a/Makefile
+++ b/Makefile
@@ -1357,6 +1357,7 @@ ifeq ($(uname_S),NONSTOP_KERNEL)
     # Added manually, see above.
     NEEDS_SSL_WITH_CURL = YesPlease
     HAVE_LIBCHARSET_H = YesPlease
+    HAVE_STRINGS_H = YesPlease
     NEEDS_LIBICONV = YesPlease
     NEEDS_LIBINTL_BEFORE_LIBICONV = YesPlease
     NO_SYS_SELECT_H = UnfortunatelyYes
--
1.7.11.7
Johannes Sixt· Dec 14, 2012, 20:30 UTC · re: David Michael · lore

Re: [PATCH 4/4] Declare that HP NonStop systems require strings.h

Am 14.12.2012 20:57, schrieb David Michael:
Show 20 quoted lines
> This platform previously included strings.h automatically.  However, the
> build system now requires an explicit option to do so.
> 
> Signed-off-by: David Michael <fedora.dm0@gmail.com>
> ---
>  Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Makefile b/Makefile
> index fb78f7f..e84b0cb 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1357,6 +1357,7 @@ ifeq ($(uname_S),NONSTOP_KERNEL)
>      # Added manually, see above.
>      NEEDS_SSL_WITH_CURL = YesPlease
>      HAVE_LIBCHARSET_H = YesPlease
> +    HAVE_STRINGS_H = YesPlease
>      NEEDS_LIBICONV = YesPlease
>      NEEDS_LIBINTL_BEFORE_LIBICONV = YesPlease
>      NO_SYS_SELECT_H = UnfortunatelyYes

If NONSTOP_KERNEL is the platform that defines __TANDEM, then this should be squashed into the previous patch, shouldn't it?

--  Hannes
Joachim Schmitz· Dec 14, 2012, 22:45 UTC · re: Johannes Sixt · lore

Re: [PATCH 4/4] Declare that HP NonStop systems require strings.h

Johannes Sixt wrote:
Show 24 quoted lines
> Am 14.12.2012 20:57, schrieb David Michael:
>> This platform previously included strings.h automatically.  However,
>> the build system now requires an explicit option to do so.
>> 
>> Signed-off-by: David Michael <fedora.dm0@gmail.com>
>> ---
>>  Makefile | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/Makefile b/Makefile
>> index fb78f7f..e84b0cb 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -1357,6 +1357,7 @@ ifeq ($(uname_S),NONSTOP_KERNEL)
>>      # Added manually, see above.
>>      NEEDS_SSL_WITH_CURL = YesPlease
>>      HAVE_LIBCHARSET_H = YesPlease
>> +    HAVE_STRINGS_H = YesPlease
>>      NEEDS_LIBICONV = YesPlease
>>      NEEDS_LIBINTL_BEFORE_LIBICONV = YesPlease
>>      NO_SYS_SELECT_H = UnfortunatelyYes
> 
> If NONSTOP_KERNEL is the platform that defines __TANDEM, then this
> should be squashed into the previous patch, shouldn't it?
Patch 4/4 does not work without 3/4, Not for HP-NonStop.
Bye, Jojo
Junio C Hamano· Dec 14, 2012, 23:17 UTC · re: Johannes Sixt · lore

Re: [PATCH 4/4] Declare that HP NonStop systems require strings.h

Johannes Sixt <j6t@kdbg.org> writes:
Show 24 quoted lines
> Am 14.12.2012 20:57, schrieb David Michael:
>> This platform previously included strings.h automatically.  However, the
>> build system now requires an explicit option to do so.
>> 
>> Signed-off-by: David Michael <fedora.dm0@gmail.com>
>> ---
>>  Makefile | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/Makefile b/Makefile
>> index fb78f7f..e84b0cb 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -1357,6 +1357,7 @@ ifeq ($(uname_S),NONSTOP_KERNEL)
>>      # Added manually, see above.
>>      NEEDS_SSL_WITH_CURL = YesPlease
>>      HAVE_LIBCHARSET_H = YesPlease
>> +    HAVE_STRINGS_H = YesPlease
>>      NEEDS_LIBICONV = YesPlease
>>      NEEDS_LIBINTL_BEFORE_LIBICONV = YesPlease
>>      NO_SYS_SELECT_H = UnfortunatelyYes
>
> If NONSTOP_KERNEL is the platform that defines __TANDEM, then this
> should be squashed into the previous patch, shouldn't it?
Correct; otherwise 3/4 would break build on that platform.

← back to recent threads