# [PATCH 4/4] Declare that HP NonStop systems require strings.h 4 messages from 2012-12-14 to 2012-12-14. Participants: David Michael, Johannes Sixt, Joachim Schmitz, Junio C Hamano. Thread: https://gitlist.dev/t/32342 ## David Michael, 2012-12-14 19:57 Subject: [PATCH 4/4] Declare that HP NonStop systems require strings.h Message-ID: URL: https://gitlist.dev/e/CAEvUa7mSOe6gs8JqkewYV%3DCXt78Y68nTFbFEfEOuCzaV5-DO8A%40mail.gmail.com ``` This platform previously included strings.h automatically. However, the build system now requires an explicit option to do so. Signed-off-by: David Michael --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index fb78f7f..e84b0cb 100644 --- a/Makefile +++ b/Makefile @@ -1357,6 +1357,7 @@ ifeq ($(uname_S),NONSTOP_KERNEL) # Added manually, see above. NEEDS_SSL_WITH_CURL = YesPlease HAVE_LIBCHARSET_H = YesPlease + HAVE_STRINGS_H = YesPlease NEEDS_LIBICONV = YesPlease NEEDS_LIBINTL_BEFORE_LIBICONV = YesPlease NO_SYS_SELECT_H = UnfortunatelyYes -- 1.7.11.7 ``` ## Johannes Sixt, 2012-12-14 20:30 Subject: Re: [PATCH 4/4] Declare that HP NonStop systems require strings.h Message-ID: <50CB8C80.6040802@kdbg.org> URL: https://gitlist.dev/e/50CB8C80.6040802%40kdbg.org In-Reply-To: ``` Am 14.12.2012 20:57, schrieb David Michael: > This platform previously included strings.h automatically. However, the > build system now requires an explicit option to do so. > > Signed-off-by: David Michael > --- > Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Makefile b/Makefile > index fb78f7f..e84b0cb 100644 > --- a/Makefile > +++ b/Makefile > @@ -1357,6 +1357,7 @@ ifeq ($(uname_S),NONSTOP_KERNEL) > # Added manually, see above. > NEEDS_SSL_WITH_CURL = YesPlease > HAVE_LIBCHARSET_H = YesPlease > + HAVE_STRINGS_H = YesPlease > NEEDS_LIBICONV = YesPlease > NEEDS_LIBINTL_BEFORE_LIBICONV = YesPlease > NO_SYS_SELECT_H = UnfortunatelyYes If NONSTOP_KERNEL is the platform that defines __TANDEM, then this should be squashed into the previous patch, shouldn't it? -- Hannes ``` ## Joachim Schmitz, 2012-12-14 22:45 Subject: Re: [PATCH 4/4] Declare that HP NonStop systems require strings.h Message-ID: URL: https://gitlist.dev/e/kaga6l%24pp8%241%40ger.gmane.org In-Reply-To: <50CB8C80.6040802@kdbg.org> ``` Johannes Sixt wrote: > Am 14.12.2012 20:57, schrieb David Michael: >> This platform previously included strings.h automatically. However, >> the build system now requires an explicit option to do so. >> >> Signed-off-by: David Michael >> --- >> Makefile | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Makefile b/Makefile >> index fb78f7f..e84b0cb 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -1357,6 +1357,7 @@ ifeq ($(uname_S),NONSTOP_KERNEL) >> # Added manually, see above. >> NEEDS_SSL_WITH_CURL = YesPlease >> HAVE_LIBCHARSET_H = YesPlease >> + HAVE_STRINGS_H = YesPlease >> NEEDS_LIBICONV = YesPlease >> NEEDS_LIBINTL_BEFORE_LIBICONV = YesPlease >> NO_SYS_SELECT_H = UnfortunatelyYes > > If NONSTOP_KERNEL is the platform that defines __TANDEM, then this > should be squashed into the previous patch, shouldn't it? Patch 4/4 does not work without 3/4, Not for HP-NonStop. Bye, Jojo ``` ## Junio C Hamano, 2012-12-14 23:17 Subject: Re: [PATCH 4/4] Declare that HP NonStop systems require strings.h Message-ID: <7vy5h0usur.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vy5h0usur.fsf%40alter.siamese.dyndns.org In-Reply-To: <50CB8C80.6040802@kdbg.org> ``` Johannes Sixt writes: > Am 14.12.2012 20:57, schrieb David Michael: >> This platform previously included strings.h automatically. However, the >> build system now requires an explicit option to do so. >> >> Signed-off-by: David Michael >> --- >> Makefile | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Makefile b/Makefile >> index fb78f7f..e84b0cb 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -1357,6 +1357,7 @@ ifeq ($(uname_S),NONSTOP_KERNEL) >> # Added manually, see above. >> NEEDS_SSL_WITH_CURL = YesPlease >> HAVE_LIBCHARSET_H = YesPlease >> + HAVE_STRINGS_H = YesPlease >> NEEDS_LIBICONV = YesPlease >> NEEDS_LIBINTL_BEFORE_LIBICONV = YesPlease >> NO_SYS_SELECT_H = UnfortunatelyYes > > If NONSTOP_KERNEL is the platform that defines __TANDEM, then this > should be squashed into the previous patch, shouldn't it? Correct; otherwise 3/4 would break build on that platform. ```