{"thread":{"id":"32342","subject":"[PATCH 4/4] Declare that HP NonStop systems require strings.h","startedAt":"2012-12-14T19:57:04Z","lastAt":"2012-12-14T23:17:00Z","messageCount":4,"participants":["David Michael","Johannes Sixt","Joachim Schmitz","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":4},"messages":[{"id":"204879","messageId":"CAEvUa7mSOe6gs8JqkewYV=CXt78Y68nTFbFEfEOuCzaV5-DO8A@mail.gmail.com","threadId":"32342","inReplyTo":null,"subject":"[PATCH 4/4] Declare that HP NonStop systems require strings.h","fromName":"David Michael","fromEmail":"fedora.dm0@gmail.com","sentAt":"2012-12-14T19:57:04Z","receivedAt":"2012-12-14T19:57:04Z","isPatch":true,"sender":{"key":"fedora.dm0@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1379865?v=4"},"body":"This platform previously included strings.h automatically.  However, the\nbuild system now requires an explicit option to do so.\n\nSigned-off-by: David Michael <fedora.dm0@gmail.com>\n---\n Makefile | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/Makefile b/Makefile\nindex fb78f7f..e84b0cb 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1357,6 +1357,7 @@ ifeq ($(uname_S),NONSTOP_KERNEL)\n     # Added manually, see above.\n     NEEDS_SSL_WITH_CURL = YesPlease\n     HAVE_LIBCHARSET_H = YesPlease\n+    HAVE_STRINGS_H = YesPlease\n     NEEDS_LIBICONV = YesPlease\n     NEEDS_LIBINTL_BEFORE_LIBICONV = YesPlease\n     NO_SYS_SELECT_H = UnfortunatelyYes\n--\n1.7.11.7\n"},{"id":"204880","messageId":"50CB8C80.6040802@kdbg.org","threadId":"32342","inReplyTo":"CAEvUa7mSOe6gs8JqkewYV=CXt78Y68nTFbFEfEOuCzaV5-DO8A@mail.gmail.com","subject":"Re: [PATCH 4/4] Declare that HP NonStop systems require strings.h","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2012-12-14T20:30:56Z","receivedAt":"2012-12-14T20:30:56Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Am 14.12.2012 20:57, schrieb David Michael:\n> This platform previously included strings.h automatically.  However, the\n> build system now requires an explicit option to do so.\n> \n> Signed-off-by: David Michael <fedora.dm0@gmail.com>\n> ---\n>  Makefile | 1 +\n>  1 file changed, 1 insertion(+)\n> \n> diff --git a/Makefile b/Makefile\n> index fb78f7f..e84b0cb 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -1357,6 +1357,7 @@ ifeq ($(uname_S),NONSTOP_KERNEL)\n>      # Added manually, see above.\n>      NEEDS_SSL_WITH_CURL = YesPlease\n>      HAVE_LIBCHARSET_H = YesPlease\n> +    HAVE_STRINGS_H = YesPlease\n>      NEEDS_LIBICONV = YesPlease\n>      NEEDS_LIBINTL_BEFORE_LIBICONV = YesPlease\n>      NO_SYS_SELECT_H = UnfortunatelyYes\n\nIf NONSTOP_KERNEL is the platform that defines __TANDEM, then this\nshould be squashed into the previous patch, shouldn't it?\n\n--  Hannes\n"},{"id":"204885","messageId":"kaga6l$pp8$1@ger.gmane.org","threadId":"32342","inReplyTo":"50CB8C80.6040802@kdbg.org","subject":"Re: [PATCH 4/4] Declare that HP NonStop systems require strings.h","fromName":"Joachim Schmitz","fromEmail":"jojo@schmitz-digital.de","sentAt":"2012-12-14T22:45:38Z","receivedAt":"2012-12-14T22:45:38Z","isPatch":true,"sender":{"key":"jojo@schmitz-digital.de","avatar":"https://avatars.githubusercontent.com/u/1786669?v=4"},"body":"Johannes Sixt wrote:\n> Am 14.12.2012 20:57, schrieb David Michael:\n>> This platform previously included strings.h automatically.  However,\n>> the build system now requires an explicit option to do so.\n>> \n>> Signed-off-by: David Michael <fedora.dm0@gmail.com>\n>> ---\n>>  Makefile | 1 +\n>>  1 file changed, 1 insertion(+)\n>> \n>> diff --git a/Makefile b/Makefile\n>> index fb78f7f..e84b0cb 100644\n>> --- a/Makefile\n>> +++ b/Makefile\n>> @@ -1357,6 +1357,7 @@ ifeq ($(uname_S),NONSTOP_KERNEL)\n>>      # Added manually, see above.\n>>      NEEDS_SSL_WITH_CURL = YesPlease\n>>      HAVE_LIBCHARSET_H = YesPlease\n>> +    HAVE_STRINGS_H = YesPlease\n>>      NEEDS_LIBICONV = YesPlease\n>>      NEEDS_LIBINTL_BEFORE_LIBICONV = YesPlease\n>>      NO_SYS_SELECT_H = UnfortunatelyYes\n> \n> If NONSTOP_KERNEL is the platform that defines __TANDEM, then this\n> should be squashed into the previous patch, shouldn't it?\n\nPatch 4/4 does not work without 3/4, Not for HP-NonStop.\n\nBye, Jojo\n"},{"id":"204888","messageId":"7vy5h0usur.fsf@alter.siamese.dyndns.org","threadId":"32342","inReplyTo":"50CB8C80.6040802@kdbg.org","subject":"Re: [PATCH 4/4] Declare that HP NonStop systems require strings.h","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-12-14T23:17:00Z","receivedAt":"2012-12-14T23:17:00Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Sixt <j6t@kdbg.org> writes:\n\n> Am 14.12.2012 20:57, schrieb David Michael:\n>> This platform previously included strings.h automatically.  However, the\n>> build system now requires an explicit option to do so.\n>> \n>> Signed-off-by: David Michael <fedora.dm0@gmail.com>\n>> ---\n>>  Makefile | 1 +\n>>  1 file changed, 1 insertion(+)\n>> \n>> diff --git a/Makefile b/Makefile\n>> index fb78f7f..e84b0cb 100644\n>> --- a/Makefile\n>> +++ b/Makefile\n>> @@ -1357,6 +1357,7 @@ ifeq ($(uname_S),NONSTOP_KERNEL)\n>>      # Added manually, see above.\n>>      NEEDS_SSL_WITH_CURL = YesPlease\n>>      HAVE_LIBCHARSET_H = YesPlease\n>> +    HAVE_STRINGS_H = YesPlease\n>>      NEEDS_LIBICONV = YesPlease\n>>      NEEDS_LIBINTL_BEFORE_LIBICONV = YesPlease\n>>      NO_SYS_SELECT_H = UnfortunatelyYes\n>\n> If NONSTOP_KERNEL is the platform that defines __TANDEM, then this\n> should be squashed into the previous patch, shouldn't it?\n\nCorrect; otherwise 3/4 would break build on that platform.\n"}]}