threads / discuss / 31950

git submodule summary doesn't return an error when passed a wrong commit/rev

Subject: git submodule summary doesn't return an error when passed a wrong commit/rev

## tl;dr

3 messages between Oct 26, 2012 and Oct 26, 2012.

replies: 2people: 2as markdown or json

Francis Moreau· Oct 26, 2012, 14:03 UTC · lore

Hi,

it seems to me that when passed an unknown rev or a wrong commit/sha1, git-submodule-summary should at least exit with an error status. Even better would be a error output.

Test was done with git version 1.7.10.4 from debian wheezy.

Thanks

-- 
Francis

Jens Lehmann· Oct 26, 2012, 19:53 UTC · re: Francis Moreau · lore

Re: git submodule summary doesn't return an error when passed a wrong commit/rev

Am 26.10.2012 16:03, schrieb Francis Moreau:

Show 5 quoted lines

> it seems to me that when passed an unknown rev or a wrong commit/sha1,
> git-submodule-summary should at least exit with an error status. Even better
> would be a error output.
> 
> Test was done with git version 1.7.10.4 from debian wheezy.

Thanks for your report, I think you found a real issue. Some quick tests showed some problems with other parameter combinations too. I'll take a deeper look the next days.

Francis Moreau· Oct 26, 2012, 19:56 UTC · re: Jens Lehmann · lore

Re: git submodule summary doesn't return an error when passed a wrong commit/rev

On Fri, Oct 26, 2012 at 9:53 PM, Jens Lehmann <Jens.Lehmann@web.de> wrote:

Show 10 quoted lines

> Am 26.10.2012 16:03, schrieb Francis Moreau:
>> it seems to me that when passed an unknown rev or a wrong commit/sha1,
>> git-submodule-summary should at least exit with an error status. Even better
>> would be a error output.
>>
>> Test was done with git version 1.7.10.4 from debian wheezy.
>
> Thanks for your report, I think you found a real issue. Some quick
> tests showed some problems with other parameter combinations too.
> I'll take a deeper look the next days.

Glad to help :)

-- 
Francis