# git submodule summary doesn't return an error when passed a wrong commit/rev 3 messages from 2012-10-26 to 2012-10-26. Participants: Francis Moreau, Jens Lehmann. Thread: https://gitlist.dev/t/31950 ## Francis Moreau, 2012-10-26 14:03 Subject: git submodule summary doesn't return an error when passed a wrong commit/rev Message-ID: URL: https://gitlist.dev/e/CAC9WiBgdgy1bwh0c16jd017q2rqQAq-suDADn2-vGw9eubBs_w%40mail.gmail.com ``` Hi, it seems to me that when passed an unknown rev or a wrong commit/sha1, git-submodule-summary should at least exit with an error status. Even better would be a error output. Test was done with git version 1.7.10.4 from debian wheezy. Thanks -- Francis ``` ## Jens Lehmann, 2012-10-26 19:53 Subject: Re: git submodule summary doesn't return an error when passed a wrong commit/rev Message-ID: <508AEA39.2020205@web.de> URL: https://gitlist.dev/e/508AEA39.2020205%40web.de In-Reply-To: ``` Am 26.10.2012 16:03, schrieb Francis Moreau: > it seems to me that when passed an unknown rev or a wrong commit/sha1, > git-submodule-summary should at least exit with an error status. Even better > would be a error output. > > Test was done with git version 1.7.10.4 from debian wheezy. Thanks for your report, I think you found a real issue. Some quick tests showed some problems with other parameter combinations too. I'll take a deeper look the next days. ``` ## Francis Moreau, 2012-10-26 19:56 Subject: Re: git submodule summary doesn't return an error when passed a wrong commit/rev Message-ID: URL: https://gitlist.dev/e/CAC9WiBj8-TmJmOowcA2KK7xYVoGoVZ8NoeTdRP9Qj6_RYr0ChQ%40mail.gmail.com In-Reply-To: <508AEA39.2020205@web.de> ``` On Fri, Oct 26, 2012 at 9:53 PM, Jens Lehmann wrote: > Am 26.10.2012 16:03, schrieb Francis Moreau: >> it seems to me that when passed an unknown rev or a wrong commit/sha1, >> git-submodule-summary should at least exit with an error status. Even better >> would be a error output. >> >> Test was done with git version 1.7.10.4 from debian wheezy. > > Thanks for your report, I think you found a real issue. Some quick > tests showed some problems with other parameter combinations too. > I'll take a deeper look the next days. Glad to help :) -- Francis ```