{"thread":{"id":"31950","subject":"git submodule summary doesn't return an error when passed a wrong commit/rev","startedAt":"2012-10-26T14:03:26Z","lastAt":"2012-10-26T19:56:02Z","messageCount":3,"participants":["Francis Moreau","Jens Lehmann"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"201950","messageId":"CAC9WiBgdgy1bwh0c16jd017q2rqQAq-suDADn2-vGw9eubBs_w@mail.gmail.com","threadId":"31950","inReplyTo":null,"subject":"git submodule summary doesn't return an error when passed a wrong commit/rev","fromName":"Francis Moreau","fromEmail":"francis.moro@gmail.com","sentAt":"2012-10-26T14:03:26Z","receivedAt":"2012-10-26T14:03:26Z","isPatch":false,"sender":{"key":"francis.moro@gmail.com","avatar":null},"body":"Hi,\n\nit seems to me that when passed an unknown rev or a wrong commit/sha1,\ngit-submodule-summary should at least exit with an error status. Even better\nwould be a error output.\n\nTest was done with git version 1.7.10.4 from debian wheezy.\n\nThanks\n-- \nFrancis\n"},{"id":"201988","messageId":"508AEA39.2020205@web.de","threadId":"31950","inReplyTo":"CAC9WiBgdgy1bwh0c16jd017q2rqQAq-suDADn2-vGw9eubBs_w@mail.gmail.com","subject":"Re: git submodule summary doesn't return an error when passed a wrong commit/rev","fromName":"Jens Lehmann","fromEmail":"jens.lehmann@web.de","sentAt":"2012-10-26T19:53:29Z","receivedAt":"2012-10-26T19:53:29Z","isPatch":false,"sender":{"key":"jens.lehmann@web.de","avatar":"https://avatars.githubusercontent.com/u/135220?v=4"},"body":"Am 26.10.2012 16:03, schrieb Francis Moreau:\n> it seems to me that when passed an unknown rev or a wrong commit/sha1,\n> git-submodule-summary should at least exit with an error status. Even better\n> would be a error output.\n> \n> Test was done with git version 1.7.10.4 from debian wheezy.\n\nThanks for your report, I think you found a real issue. Some quick\ntests showed some problems with other parameter combinations too.\nI'll take a deeper look the next days.\n"},{"id":"201990","messageId":"CAC9WiBj8-TmJmOowcA2KK7xYVoGoVZ8NoeTdRP9Qj6_RYr0ChQ@mail.gmail.com","threadId":"31950","inReplyTo":"508AEA39.2020205@web.de","subject":"Re: git submodule summary doesn't return an error when passed a wrong commit/rev","fromName":"Francis Moreau","fromEmail":"francis.moro@gmail.com","sentAt":"2012-10-26T19:56:02Z","receivedAt":"2012-10-26T19:56:02Z","isPatch":false,"sender":{"key":"francis.moro@gmail.com","avatar":null},"body":"On Fri, Oct 26, 2012 at 9:53 PM, Jens Lehmann <Jens.Lehmann@web.de> wrote:\n> Am 26.10.2012 16:03, schrieb Francis Moreau:\n>> it seems to me that when passed an unknown rev or a wrong commit/sha1,\n>> git-submodule-summary should at least exit with an error status. Even better\n>> would be a error output.\n>>\n>> Test was done with git version 1.7.10.4 from debian wheezy.\n>\n> Thanks for your report, I think you found a real issue. Some quick\n> tests showed some problems with other parameter combinations too.\n> I'll take a deeper look the next days.\n\nGlad to help :)\n\n-- \nFrancis\n"}]}