[PATCH] gitweb.cgi: fix "comitter_tz" typo in feed

Dylan Alex Simon· Oct 11, 2012, 20:40 UTC · lore

gitweb's feeds sometimes contained committer timestamps in the wrong timezone due to a misspelling.

Signed-off-by: Dylan Simon <dylan@dylex.net>
---
 gitweb/gitweb.perl |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to gitweb/gitweb.perl +1 −1

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 7f8c187..10ed9e5 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -8028,7 +8028,7 @@ sub git_feed {
 		%latest_commit = %{$commitlist[0]};
 		my $latest_epoch = $latest_commit{'committer_epoch'};
 		exit_if_unmodified_since($latest_epoch);
-		%latest_date = parse_date($latest_epoch, $latest_commit{'comitter_tz'});
+		%latest_date = parse_date($latest_epoch, $latest_commit{'committer_tz'});
 	}
 	print $cgi->header(
 		-type => $content_type,

-- 
1.7.10.3

Junio C Hamano· Oct 12, 2012, 15:43 UTC · re: Dylan Alex Simon · lore

Re: [PATCH] gitweb.cgi: fix "comitter_tz" typo in feed

Dylan Alex Simon <dylan@dylex.net> writes:

Show 5 quoted lines

> gitweb's feeds sometimes contained committer timestamps in the wrong timezone
> due to a misspelling.
>
> Signed-off-by: Dylan Simon <dylan@dylex.net>
> ---

This dates back to 6368d9f (gitweb: Always call parse_date with timezone parameter, 2011-03-19) which was in 1.7.4.2 and has been moved around without anybody noticing.

For any patch that is more complex, I would say "We've lived with this bug for a long time and nobody was hurt enough to complain, so it can wait until the next round", but I'll apply it directly to 'maint' because the fix is so trivially correct. Otherwise I'll forget ;-)

Thanks.

Show 16 quoted lines

>  gitweb/gitweb.perl |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 7f8c187..10ed9e5 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -8028,7 +8028,7 @@ sub git_feed {
>  		%latest_commit = %{$commitlist[0]};
>  		my $latest_epoch = $latest_commit{'committer_epoch'};
>  		exit_if_unmodified_since($latest_epoch);
> -		%latest_date = parse_date($latest_epoch, $latest_commit{'comitter_tz'});
> +		%latest_date = parse_date($latest_epoch, $latest_commit{'committer_tz'});
>  	}
>  	print $cgi->header(
>  		-type => $content_type,

patchgitweb.cgi: fix "comitter_tz" typo in feed