# [PATCH] gitweb.cgi: fix "comitter_tz" typo in feed

2 messages from 2012-10-11 to 2012-10-12. Participants: Dylan Alex Simon, Junio C Hamano.
Thread: https://gitlist.dev/t/31793

## Dylan Alex Simon, 2012-10-11 20:40

Subject: [PATCH] gitweb.cgi: fix "comitter_tz" typo in feed
Message-ID: <20121011204035.GA19361@datura.dylex.net>
URL: https://gitlist.dev/e/20121011204035.GA19361%40datura.dylex.net

```
gitweb's feeds sometimes contained committer timestamps in the wrong timezone
due to a misspelling.

Signed-off-by: Dylan Simon <dylan@dylex.net>
---
 gitweb/gitweb.perl |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 7f8c187..10ed9e5 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -8028,7 +8028,7 @@ sub git_feed {
 		%latest_commit = %{$commitlist[0]};
 		my $latest_epoch = $latest_commit{'committer_epoch'};
 		exit_if_unmodified_since($latest_epoch);
-		%latest_date = parse_date($latest_epoch, $latest_commit{'comitter_tz'});
+		%latest_date = parse_date($latest_epoch, $latest_commit{'committer_tz'});
 	}
 	print $cgi->header(
 		-type => $content_type,
-- 
1.7.10.3

```

## Junio C Hamano, 2012-10-12 15:43

Subject: Re: [PATCH] gitweb.cgi: fix "comitter_tz" typo in feed
Message-ID: <7v391j66ig.fsf@alter.siamese.dyndns.org>
URL: https://gitlist.dev/e/7v391j66ig.fsf%40alter.siamese.dyndns.org
In-Reply-To: <20121011204035.GA19361@datura.dylex.net>

```
Dylan Alex Simon <dylan@dylex.net> writes:

> gitweb's feeds sometimes contained committer timestamps in the wrong timezone
> due to a misspelling.
>
> Signed-off-by: Dylan Simon <dylan@dylex.net>
> ---

This dates back to 6368d9f (gitweb: Always call parse_date with
timezone parameter, 2011-03-19) which was in 1.7.4.2 and has been
moved around without anybody noticing.

For any patch that is more complex, I would say "We've lived with
this bug for a long time and nobody was hurt enough to complain, so
it can wait until the next round", but I'll apply it directly to
'maint' because the fix is so trivially correct.  Otherwise I'll
forget ;-)

Thanks.

>  gitweb/gitweb.perl |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 7f8c187..10ed9e5 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -8028,7 +8028,7 @@ sub git_feed {
>  		%latest_commit = %{$commitlist[0]};
>  		my $latest_epoch = $latest_commit{'committer_epoch'};
>  		exit_if_unmodified_since($latest_epoch);
> -		%latest_date = parse_date($latest_epoch, $latest_commit{'comitter_tz'});
> +		%latest_date = parse_date($latest_epoch, $latest_commit{'committer_tz'});
>  	}
>  	print $cgi->header(
>  		-type => $content_type,

```