{"thread":{"id":"31793","subject":"[PATCH] gitweb.cgi: fix \"comitter_tz\" typo in feed","startedAt":"2012-10-11T20:40:35Z","lastAt":"2012-10-12T15:43:03Z","messageCount":2,"participants":["Dylan Alex Simon","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"201025","messageId":"20121011204035.GA19361@datura.dylex.net","threadId":"31793","inReplyTo":null,"subject":"[PATCH] gitweb.cgi: fix \"comitter_tz\" typo in feed","fromName":"Dylan Alex Simon","fromEmail":"dylan@dylex.net","sentAt":"2012-10-11T20:40:35Z","receivedAt":"2012-10-11T20:40:35Z","isPatch":true,"sender":{"key":"dylan@dylex.net","avatar":null},"body":"gitweb's feeds sometimes contained committer timestamps in the wrong timezone\ndue to a misspelling.\n\nSigned-off-by: Dylan Simon <dylan@dylex.net>\n---\n gitweb/gitweb.perl |    2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 7f8c187..10ed9e5 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -8028,7 +8028,7 @@ sub git_feed {\n \t\t%latest_commit = %{$commitlist[0]};\n \t\tmy $latest_epoch = $latest_commit{'committer_epoch'};\n \t\texit_if_unmodified_since($latest_epoch);\n-\t\t%latest_date = parse_date($latest_epoch, $latest_commit{'comitter_tz'});\n+\t\t%latest_date = parse_date($latest_epoch, $latest_commit{'committer_tz'});\n \t}\n \tprint $cgi->header(\n \t\t-type => $content_type,\n-- \n1.7.10.3\n"},{"id":"201058","messageId":"7v391j66ig.fsf@alter.siamese.dyndns.org","threadId":"31793","inReplyTo":"20121011204035.GA19361@datura.dylex.net","subject":"Re: [PATCH] gitweb.cgi: fix \"comitter_tz\" typo in feed","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-10-12T15:43:03Z","receivedAt":"2012-10-12T15:43:03Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Dylan Alex Simon <dylan@dylex.net> writes:\n\n> gitweb's feeds sometimes contained committer timestamps in the wrong timezone\n> due to a misspelling.\n>\n> Signed-off-by: Dylan Simon <dylan@dylex.net>\n> ---\n\nThis dates back to 6368d9f (gitweb: Always call parse_date with\ntimezone parameter, 2011-03-19) which was in 1.7.4.2 and has been\nmoved around without anybody noticing.\n\nFor any patch that is more complex, I would say \"We've lived with\nthis bug for a long time and nobody was hurt enough to complain, so\nit can wait until the next round\", but I'll apply it directly to\n'maint' because the fix is so trivially correct.  Otherwise I'll\nforget ;-)\n\nThanks.\n\n>  gitweb/gitweb.perl |    2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\n> index 7f8c187..10ed9e5 100755\n> --- a/gitweb/gitweb.perl\n> +++ b/gitweb/gitweb.perl\n> @@ -8028,7 +8028,7 @@ sub git_feed {\n>  \t\t%latest_commit = %{$commitlist[0]};\n>  \t\tmy $latest_epoch = $latest_commit{'committer_epoch'};\n>  \t\texit_if_unmodified_since($latest_epoch);\n> -\t\t%latest_date = parse_date($latest_epoch, $latest_commit{'comitter_tz'});\n> +\t\t%latest_date = parse_date($latest_epoch, $latest_commit{'committer_tz'});\n>  \t}\n>  \tprint $cgi->header(\n>  \t\t-type => $content_type,\n"}]}