threads / patch / 30704

patcht3510 (cherry-pick-sequence): add missing '&&'

Subject: [PATCH] t3510 (cherry-pick-sequence): add missing '&&'

## tl;dr

One message between Jun 4, 2012 and Jun 4, 2012. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Ramkumar Ramachandra· Jun 4, 2012, 16:42 UTC · lore

Breaks in a test assertion's && chain can potentially hide failures from earlier commands in the chain. Fix an instance of this in the setup.

Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
 Minor nit.  There aren't any other && chaining breakages in the file.
 t/t3510-cherry-pick-sequence.sh |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to t/t3510-cherry-pick-sequence.sh +1 −1
diff --git a/t/t3510-cherry-pick-sequence.sh b/t/t3510-cherry-pick-sequence.sh
index 97f3710..f4e6450 100755
--- a/t/t3510-cherry-pick-sequence.sh
+++ b/t/t3510-cherry-pick-sequence.sh
@@ -31,7 +31,7 @@ test_cmp_rev () {
 }
 
 test_expect_success setup '
-	git config advice.detachedhead false
+	git config advice.detachedhead false &&
 	echo unrelated >unrelated &&
 	git add unrelated &&
 	test_commit initial foo a &&
-- 
1.7.10

← back to recent threads