{"thread":{"id":"30704","subject":"[PATCH] t3510 (cherry-pick-sequence): add missing '&&'","startedAt":"2012-06-04T16:42:44Z","lastAt":"2012-06-04T16:42:44Z","messageCount":1,"participants":["Ramkumar Ramachandra"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"192814","messageId":"1338828164-15316-1-git-send-email-artagnon@gmail.com","threadId":"30704","inReplyTo":null,"subject":"[PATCH] t3510 (cherry-pick-sequence): add missing '&&'","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2012-06-04T16:42:44Z","receivedAt":"2012-06-04T16:42:44Z","isPatch":true,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"Breaks in a test assertion's && chain can potentially hide failures\nfrom earlier commands in the chain.  Fix an instance of this in the\nsetup.\n\nSigned-off-by: Ramkumar Ramachandra <artagnon@gmail.com>\n---\n Minor nit.  There aren't any other && chaining breakages in the file.\n\n t/t3510-cherry-pick-sequence.sh |    2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t3510-cherry-pick-sequence.sh b/t/t3510-cherry-pick-sequence.sh\nindex 97f3710..f4e6450 100755\n--- a/t/t3510-cherry-pick-sequence.sh\n+++ b/t/t3510-cherry-pick-sequence.sh\n@@ -31,7 +31,7 @@ test_cmp_rev () {\n }\n \n test_expect_success setup '\n-\tgit config advice.detachedhead false\n+\tgit config advice.detachedhead false &&\n \techo unrelated >unrelated &&\n \tgit add unrelated &&\n \ttest_commit initial foo a &&\n-- \n1.7.10\n"}]}