git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] t3510 (cherry-pick-sequence): add missing '&&'

From
Ramkumar Ramachandra <artagnon@gmail.com>
Date
Jun 4, 2012, 16:42 UTC
Message-ID
<1338828164-15316-1-git-send-email-artagnon@gmail.com>

Breaks in a test assertion's && chain can potentially hide failures from earlier commands in the chain. Fix an instance of this in the setup.

Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
 Minor nit.  There aren't any other && chaining breakages in the file.
 t/t3510-cherry-pick-sequence.sh |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t3510-cherry-pick-sequence.sh b/t/t3510-cherry-pick-sequence.sh
index 97f3710..f4e6450 100755
--- a/t/t3510-cherry-pick-sequence.sh
+++ b/t/t3510-cherry-pick-sequence.sh
@@ -31,7 +31,7 @@ test_cmp_rev () {
 }
 
 test_expect_success setup '
-	git config advice.detachedhead false
+	git config advice.detachedhead false &&
 	echo unrelated >unrelated &&
 	git add unrelated &&
 	test_commit initial foo a &&
-- 
1.7.10
Message 1 of 1 in “t3510 (cherry-pick-sequence): add missing '&&'”
  1. t3510 (cherry-pick-sequence): add missing '&&'Ramkumar Ramachandra, Jun 4, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.