threads / patch / 29421

v4git on Mac OS and precomposed unicode

Subject: [PATCH V4] git on Mac OS and precomposed unicode

## tl;dr

2 messages between Jan 21, 2012 and Jan 21, 2012. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Torsten Bögershausen· Jan 21, 2012, 19:36 UTC · lore

Changes since V3:

- Be much more defensive:
  Do not set core.precomposedunicode=true, even if the file system
  probing indicates that it could be true.
  (but we don't say that it should be true).
  This is to keep better backward compatibility within git.
  The user needs to manually enable the precomposition.
  However, the .git/config indicates that we have a new
  configuration variable, and will encourage people to use it.

- compat/precomposed_utf8.c: 
    - re-order #includes
    - Added some empty lines to make code easier to read. 
    - Small fixes (xmalloc, errno handling)

- Make function names more consistent by renaming these functions:
    argv_precompose() -> precompose_argv()
    str_precompose() -> precompose_str()
- Improved the commit message

Torsten Bögershausen (1):
  git on Mac OS and precomposed unicode

 Documentation/config.txt     |    9 ++
 Makefile                     |    3 +
 builtin/init-db.c            |    2 +
 compat/precomposed_utf8.c    |  208 ++++++++++++++++++++++++++++++++++++++++++
 compat/precomposed_utf8.h    |   30 ++++++
 git-compat-util.h            |    9 ++
 git.c                        |    1 +
 t/t3910-mac-os-precompose.sh |  117 +++++++++++++++++++++++
 8 files changed, 379 insertions(+), 0 deletions(-)
 create mode 100644 compat/precomposed_utf8.c
 create mode 100644 compat/precomposed_utf8.h
 create mode 100755 t/t3910-mac-os-precompose.sh

-- 
1.7.8.rc0.43.gb49a8

Junio C Hamano· Jan 21, 2012, 22:14 UTC · re: Torsten Bögershausen · lore

Re: [PATCH V4] git on Mac OS and precomposed unicode

Torsten Bögershausen <tboegi@web.de> writes:

Show 20 quoted lines

> Changes since V3:
>
> - Be much more defensive:
>   Do not set core.precomposedunicode=true, even if the file system
>   probing indicates that it could be true.
>   (but we don't say that it should be true).
>   This is to keep better backward compatibility within git.
>   The user needs to manually enable the precomposition.
>   However, the .git/config indicates that we have a new
>   configuration variable, and will encourage people to use it.
>
> - compat/precomposed_utf8.c: 
>     - re-order #includes
>     - Added some empty lines to make code easier to read. 
>     - Small fixes (xmalloc, errno handling)
>
> - Make function names more consistent by renaming these functions:
>     argv_precompose() -> precompose_argv()
>     str_precompose() -> precompose_str()
> - Improved the commit message

Next time around, please place these after --- lines in the patch message itself, without making a single-patch series with a separate cover letter.

Thanks.