{"thread":{"id":"29421","subject":"[PATCH V4] git on Mac OS and precomposed unicode","startedAt":"2012-01-21T19:36:45Z","lastAt":"2012-01-21T22:14:41Z","messageCount":2,"participants":["Torsten Bögershausen","Junio C Hamano"],"isPatch":true,"patchVersion":4,"patchTotal":null},"messages":[{"id":"182903","messageId":"201201212036.46681.tboegi@web.de","threadId":"29421","inReplyTo":null,"subject":"[PATCH V4] git on Mac OS and precomposed unicode","fromName":"Torsten Bögershausen","fromEmail":"tboegi@web.de","sentAt":"2012-01-21T19:36:45Z","receivedAt":"2012-01-21T19:36:45Z","isPatch":true,"sender":{"key":"tboegi@web.de","avatar":"https://avatars.githubusercontent.com/u/7138363?v=4"},"body":"Changes since V3:\n\n- Be much more defensive:\n  Do not set core.precomposedunicode=true, even if the file system\n  probing indicates that it could be true.\n  (but we don't say that it should be true).\n  This is to keep better backward compatibility within git.\n  The user needs to manually enable the precomposition.\n  However, the .git/config indicates that we have a new\n  configuration variable, and will encourage people to use it.\n\n- compat/precomposed_utf8.c: \n    - re-order #includes\n    - Added some empty lines to make code easier to read. \n    - Small fixes (xmalloc, errno handling)\n\n- Make function names more consistent by renaming these functions:\n    argv_precompose() -> precompose_argv()\n    str_precompose() -> precompose_str()\n- Improved the commit message\n\n\nTorsten Bögershausen (1):\n  git on Mac OS and precomposed unicode\n\n Documentation/config.txt     |    9 ++\n Makefile                     |    3 +\n builtin/init-db.c            |    2 +\n compat/precomposed_utf8.c    |  208 ++++++++++++++++++++++++++++++++++++++++++\n compat/precomposed_utf8.h    |   30 ++++++\n git-compat-util.h            |    9 ++\n git.c                        |    1 +\n t/t3910-mac-os-precompose.sh |  117 +++++++++++++++++++++++\n 8 files changed, 379 insertions(+), 0 deletions(-)\n create mode 100644 compat/precomposed_utf8.c\n create mode 100644 compat/precomposed_utf8.h\n create mode 100755 t/t3910-mac-os-precompose.sh\n\n-- \n1.7.8.rc0.43.gb49a8\n"},{"id":"182911","messageId":"7vwr8kaejy.fsf@alter.siamese.dyndns.org","threadId":"29421","inReplyTo":"201201212036.46681.tboegi@web.de","subject":"Re: [PATCH V4] git on Mac OS and precomposed unicode","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-01-21T22:14:41Z","receivedAt":"2012-01-21T22:14:41Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Torsten Bögershausen <tboegi@web.de> writes:\n\n> Changes since V3:\n>\n> - Be much more defensive:\n>   Do not set core.precomposedunicode=true, even if the file system\n>   probing indicates that it could be true.\n>   (but we don't say that it should be true).\n>   This is to keep better backward compatibility within git.\n>   The user needs to manually enable the precomposition.\n>   However, the .git/config indicates that we have a new\n>   configuration variable, and will encourage people to use it.\n>\n> - compat/precomposed_utf8.c: \n>     - re-order #includes\n>     - Added some empty lines to make code easier to read. \n>     - Small fixes (xmalloc, errno handling)\n>\n> - Make function names more consistent by renaming these functions:\n>     argv_precompose() -> precompose_argv()\n>     str_precompose() -> precompose_str()\n> - Improved the commit message\n\nNext time around, please place these after --- lines in the patch message\nitself, without making a single-patch series with a separate cover letter.\n\nThanks.\n"}]}