Re: [PATCH V4] git on Mac OS and precomposed unicode

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 21, 2012, 22:14 UTC
Message-ID: <7vwr8kaejy.fsf@alter.siamese.dyndns.org>
In-Reply-To: <201201212036.46681.tboegi@web.de>

Torsten Bögershausen <tboegi@web.de> writes:

Show 20 quoted lines

> Changes since V3:
>
> - Be much more defensive:
>   Do not set core.precomposedunicode=true, even if the file system
>   probing indicates that it could be true.
>   (but we don't say that it should be true).
>   This is to keep better backward compatibility within git.
>   The user needs to manually enable the precomposition.
>   However, the .git/config indicates that we have a new
>   configuration variable, and will encourage people to use it.
>
> - compat/precomposed_utf8.c: 
>     - re-order #includes
>     - Added some empty lines to make code easier to read. 
>     - Small fixes (xmalloc, errno handling)
>
> - Make function names more consistent by renaming these functions:
>     argv_precompose() -> precompose_argv()
>     str_precompose() -> precompose_str()
> - Improved the commit message

Next time around, please place these after --- lines in the patch message itself, without making a single-patch series with a separate cover letter.

Thanks.