threads / discuss / 27914
Subject: Http/s authentication failure with some git versions
Hey, Following command: git clone "https://git%40app.example.com:myp...@git.example.com/app-comm
This works fine with git versions: 1.7.4.1 1.7.6
and fails with: 1.7.1 1.7.2.5 1.7.33
does anyone know why, or if there was a particular bug fixed? I don't want to upgrade git on the production systems without a reason.. Can't find anything and I'm getting desperate...
Thank you, Christoph
Jeff KingRe: Http/s authentication failure with some git versions
On Mon, Jul 25, 2011 at 03:23:17PM +0200, Christoph Blank wrote:
> Following command: > git clone "https://git%40app.example.com:myp...@git.example.com/app-comm > > This works fine with git versions: > 1.7.4.1 > 1.7.6 > > and fails with: > 1.7.1 > 1.7.2.5 > 1.7.33 > > does anyone know why, or if there was a particular bug fixed? > I don't want to upgrade git on the production systems without a reason.. > Can't find anything and I'm getting desperate...
I skimmed through:
git log v1.7.3.3..v1.7.4.1 http.c
and came up with:
commit f39f72d8cf03b61407f64460eba3357ec532280e Author: Gabriel Corona <gabriel.corona@enst-bretagne.fr> Date: Sun Nov 14 02:51:15 2010 +0100
Fix username and password extraction from HTTP URLs
Change the authentification initialisation to percent-decode username
and password for HTTP URLs.which seems a likely candidate based on the example you gave. You could try cherry-picking that commit onto your older version if you don't want to do a full upgrade.
Now, I happened to know that http.c was where the relevant code lived (because I was working on it recently), and limiting my search to commits that touched that file made the list quite short. But knowing nothing else except a test case that works on some versions and not on others, you could always "git bisect", which would find the relevant commit for you.
-Peff
Re: Http/s authentication failure with some git versions
Thanks a lot for the pointer! I will upgrade to a newer version
greetings, Christoph
On Mon, Jul 25, 2011 at 10:32:23AM -0600, Jeff King wrote:
> On Mon, Jul 25, 2011 at 03:23:17PM +0200, Christoph Blank wrote: > > > Following command: > > git clone "https://git%40app.example.com:myp...@git.example.com/app-comm > > > > This works fine with git versions: > > 1.7.4.1 > > 1.7.6 > > > > and fails with: > > 1.7.1 > > 1.7.2.5 > > 1.7.33 > > > > does anyone know why, or if there was a particular bug fixed? > > I don't want to upgrade git on the production systems without a reason.. > > Can't find anything and I'm getting desperate... > > I skimmed through: > > git log v1.7.3.3..v1.7.4.1 http.c > > and came up with: > > commit f39f72d8cf03b61407f64460eba3357ec532280e > Author: Gabriel Corona <gabriel.corona@enst-bretagne.fr> > Date: Sun Nov 14 02:51:15 2010 +0100 > > Fix username and password extraction from HTTP URLs > > Change the authentification initialisation to percent-decode username > and password for HTTP URLs. > > which seems a likely candidate based on the example you gave. You could > try cherry-picking that commit onto your older version if you don't want > to do a full upgrade. > > Now, I happened to know that http.c was where the relevant code lived > (because I was working on it recently), and limiting my search to > commits that touched that file made the list quite short. But knowing > nothing else except a test case that works on some versions and not on > others, you could always "git bisect", which would find the relevant > commit for you. > > -Peff > -- > To unsubscribe from this list: send the line "unsubscribe git" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html