{"thread":{"id":"27914","subject":"Http/s authentication failure with some git versions","startedAt":"2011-07-25T13:23:17Z","lastAt":"2011-07-25T19:39:51Z","messageCount":3,"participants":["Christoph Blank","Jeff King"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"171989","messageId":"20110725132317.GA21590@tp","threadId":"27914","inReplyTo":null,"subject":"Http/s authentication failure with some git versions","fromName":"Christoph Blank","fromEmail":"sol@textmode.at","sentAt":"2011-07-25T13:23:17Z","receivedAt":"2011-07-25T13:23:17Z","isPatch":false,"sender":{"key":"sol@textmode.at","avatar":null},"body":"Hey, \nFollowing command: \ngit clone \"https://git%40app.example.com:myp...@git.example.com/app-comm \n\nThis works fine with git versions: \n1.7.4.1 \n1.7.6 \n\nand fails with: \n1.7.1 \n1.7.2.5 \n1.7.33 \n\ndoes anyone know why, or if there was a particular bug fixed? \nI don't want to upgrade git on the production systems without a reason..\nCan't find anything and I'm getting desperate...\n\nThank you,\nChristoph\n"},{"id":"171994","messageId":"20110725163223.GB7071@sigill.intra.peff.net","threadId":"27914","inReplyTo":"20110725132317.GA21590@tp","subject":"Re: Http/s authentication failure with some git versions","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2011-07-25T16:32:23Z","receivedAt":"2011-07-25T16:32:23Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Mon, Jul 25, 2011 at 03:23:17PM +0200, Christoph Blank wrote:\n\n> Following command: \n> git clone \"https://git%40app.example.com:myp...@git.example.com/app-comm \n> \n> This works fine with git versions: \n> 1.7.4.1 \n> 1.7.6 \n> \n> and fails with: \n> 1.7.1 \n> 1.7.2.5 \n> 1.7.33 \n> \n> does anyone know why, or if there was a particular bug fixed? \n> I don't want to upgrade git on the production systems without a reason..\n> Can't find anything and I'm getting desperate...\n\nI skimmed through:\n\n git log v1.7.3.3..v1.7.4.1 http.c\n\nand came up with:\n\n commit f39f72d8cf03b61407f64460eba3357ec532280e\n Author: Gabriel Corona \n Date: Sun Nov 14 02:51:15 2010 +0100\n\n Fix username and password extraction from HTTP URLs\n\n Change the authentification initialisation to percent-decode username\n and password for HTTP URLs.\n\nwhich seems a likely candidate based on the example you gave. You could\ntry cherry-picking that commit onto your older version if you don't want\nto do a full upgrade.\n\nNow, I happened to know that http.c was where the relevant code lived\n(because I was working on it recently), and limiting my search to\ncommits that touched that file made the list quite short. But knowing\nnothing else except a test case that works on some versions and not on\nothers, you could always \"git bisect\", which would find the relevant\ncommit for you.\n\n-Peff\n"},{"id":"172005","messageId":"20110725193951.GB20953@tp","threadId":"27914","inReplyTo":"20110725163223.GB7071@sigill.intra.peff.net","subject":"Re: Http/s authentication failure with some git versions","fromName":"Christoph Blank","fromEmail":"sol@textmode.at","sentAt":"2011-07-25T19:39:51Z","receivedAt":"2011-07-25T19:39:51Z","isPatch":false,"sender":{"key":"sol@textmode.at","avatar":null},"body":"Thanks a lot for the pointer!\nI will upgrade to a newer version\n\ngreetings,\nChristoph\n\nOn Mon, Jul 25, 2011 at 10:32:23AM -0600, Jeff King wrote:\n> On Mon, Jul 25, 2011 at 03:23:17PM +0200, Christoph Blank wrote:\n> \n> > Following command: \n> > git clone \"https://git%40app.example.com:myp...@git.example.com/app-comm \n> > \n> > This works fine with git versions: \n> > 1.7.4.1 \n> > 1.7.6 \n> > \n> > and fails with: \n> > 1.7.1 \n> > 1.7.2.5 \n> > 1.7.33 \n> > \n> > does anyone know why, or if there was a particular bug fixed? \n> > I don't want to upgrade git on the production systems without a reason..\n> > Can't find anything and I'm getting desperate...\n> \n> I skimmed through:\n> \n> git log v1.7.3.3..v1.7.4.1 http.c\n> \n> and came up with:\n> \n> commit f39f72d8cf03b61407f64460eba3357ec532280e\n> Author: Gabriel Corona \n> Date: Sun Nov 14 02:51:15 2010 +0100\n> \n> Fix username and password extraction from HTTP URLs\n> \n> Change the authentification initialisation to percent-decode username\n> and password for HTTP URLs.\n> \n> which seems a likely candidate based on the example you gave. You could\n> try cherry-picking that commit onto your older version if you don't want\n> to do a full upgrade.\n> \n> Now, I happened to know that http.c was where the relevant code lived\n> (because I was working on it recently), and limiting my search to\n> commits that touched that file made the list quite short. But knowing\n> nothing else except a test case that works on some versions and not on\n> others, you could always \"git bisect\", which would find the relevant\n> commit for you.\n> \n> -Peff\n> --\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at http://vger.kernel.org/majordomo-info.html\n"}]}