Re: Http/s authentication failure with some git versions

From: Jeff King <peff@peff.net>
Date: Jul 25, 2011, 16:32 UTC
Message-ID: <20110725163223.GB7071@sigill.intra.peff.net>
In-Reply-To: <20110725132317.GA21590@tp>

On Mon, Jul 25, 2011 at 03:23:17PM +0200, Christoph Blank wrote:

Show 15 quoted lines

> Following command: 
> git clone "https://git%40app.example.com:myp...@git.example.com/app-comm 
> 
> This works fine with git versions: 
> 1.7.4.1 
> 1.7.6 
> 
> and fails with: 
> 1.7.1 
> 1.7.2.5 
> 1.7.33 
> 
> does anyone know why, or if there was a particular bug fixed? 
> I don't want to upgrade git on the production systems without a reason..
> Can't find anything and I'm getting desperate...

I skimmed through:

  git log v1.7.3.3..v1.7.4.1 http.c

and came up with:

  commit f39f72d8cf03b61407f64460eba3357ec532280e
  Author: Gabriel Corona <gabriel.corona@enst-bretagne.fr>
  Date:   Sun Nov 14 02:51:15 2010 +0100

      Fix username and password extraction from HTTP URLs

      Change the authentification initialisation to percent-decode username
      and password for HTTP URLs.

which seems a likely candidate based on the example you gave. You could try cherry-picking that commit onto your older version if you don't want to do a full upgrade.

Now, I happened to know that http.c was where the relevant code lived (because I was working on it recently), and limiting my search to commits that touched that file made the list quite short. But knowing nothing else except a test case that works on some versions and not on others, you could always "git bisect", which would find the relevant commit for you.

-Peff