[PATCH] gitweb: 'pickaxe' feature requires 'search' enabled

Jakub Narebski· Jun 20, 2011, 21:40 UTC · lore

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
This is something I noticed when working on improving gitweb search.

 gitweb/gitweb.perl |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Show changes to gitweb/gitweb.perl +1 −0

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index c9e6426..1a59781 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -342,6 +342,7 @@ our %feature = (
 	# Enable the pickaxe search, which will list the commits that modified
 	# a given string in a file. This can be practical and quite faster
 	# alternative to 'blame', but still potentially CPU-intensive.
+	# Note that you need to have 'search' feature enabled too.
 
 	# To enable system wide have in $GITWEB_CONFIG
 	# $feature{'pickaxe'}{'default'} = [1];

Jakub Narebski· Jun 21, 2011, 06:41 UTC · re: Jakub Narebski · lore

[PATCH (amend)] gitweb: 'pickaxe' and 'grep' features requires 'search' to be enabled

Both 'pickaxe' (searching changes) and 'grep' (searching files) require basic 'search' feature to be enabled to work. Enabling e.g. only 'pickaxe' won't work.

Add a comment about this.

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
I'm sorry, I forgot that this issue applies to 'grep' feature too.

 gitweb/gitweb.perl |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Show changes to gitweb/gitweb.perl +2 −0

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index c9e6426..63af8d4 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -328,6 +328,7 @@ our %feature = (
 	# Enable grep search, which will list the files in currently selected
 	# tree containing the given string. Enabled by default. This can be
 	# potentially CPU-intensive, of course.
+	# Note that you need to have 'search' feature enabled too.
 
 	# To enable system wide have in $GITWEB_CONFIG
 	# $feature{'grep'}{'default'} = [1];
@@ -342,6 +343,7 @@ our %feature = (
 	# Enable the pickaxe search, which will list the commits that modified
 	# a given string in a file. This can be practical and quite faster
 	# alternative to 'blame', but still potentially CPU-intensive.
+	# Note that you need to have 'search' feature enabled too.
 
 	# To enable system wide have in $GITWEB_CONFIG
 	# $feature{'pickaxe'}{'default'} = [1];

patchgitweb: 'pickaxe' feature requires 'search' enabled