# [PATCH] gitweb: 'pickaxe' feature requires 'search' enabled 2 messages from 2011-06-20 to 2011-06-21. Participants: Jakub Narebski. Thread: https://gitlist.dev/t/27666 ## Jakub Narebski, 2011-06-20 21:40 Subject: [PATCH] gitweb: 'pickaxe' feature requires 'search' enabled Message-ID: <20110620213904.11650.60345.stgit@localhost.localdomain> URL: https://gitlist.dev/e/20110620213904.11650.60345.stgit%40localhost.localdomain ``` Signed-off-by: Jakub Narebski --- This is something I noticed when working on improving gitweb search. gitweb/gitweb.perl | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index c9e6426..1a59781 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -342,6 +342,7 @@ our %feature = ( # Enable the pickaxe search, which will list the commits that modified # a given string in a file. This can be practical and quite faster # alternative to 'blame', but still potentially CPU-intensive. + # Note that you need to have 'search' feature enabled too. # To enable system wide have in $GITWEB_CONFIG # $feature{'pickaxe'}{'default'} = [1]; ``` ## Jakub Narebski, 2011-06-21 06:41 Subject: [PATCH (amend)] gitweb: 'pickaxe' and 'grep' features requires 'search' to be enabled Message-ID: <20110621064037.17169.36375.stgit@localhost.localdomain> URL: https://gitlist.dev/e/20110621064037.17169.36375.stgit%40localhost.localdomain In-Reply-To: <20110620213904.11650.60345.stgit@localhost.localdomain> ``` Both 'pickaxe' (searching changes) and 'grep' (searching files) require basic 'search' feature to be enabled to work. Enabling e.g. only 'pickaxe' won't work. Add a comment about this. Signed-off-by: Jakub Narebski --- I'm sorry, I forgot that this issue applies to 'grep' feature too. gitweb/gitweb.perl | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index c9e6426..63af8d4 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -328,6 +328,7 @@ our %feature = ( # Enable grep search, which will list the files in currently selected # tree containing the given string. Enabled by default. This can be # potentially CPU-intensive, of course. + # Note that you need to have 'search' feature enabled too. # To enable system wide have in $GITWEB_CONFIG # $feature{'grep'}{'default'} = [1]; @@ -342,6 +343,7 @@ our %feature = ( # Enable the pickaxe search, which will list the commits that modified # a given string in a file. This can be practical and quite faster # alternative to 'blame', but still potentially CPU-intensive. + # Note that you need to have 'search' feature enabled too. # To enable system wide have in $GITWEB_CONFIG # $feature{'pickaxe'}{'default'} = [1]; ```