{"thread":{"id":"27666","subject":"[PATCH] gitweb: 'pickaxe' feature requires 'search' enabled","startedAt":"2011-06-20T21:40:07Z","lastAt":"2011-06-21T06:41:16Z","messageCount":2,"participants":["Jakub Narebski"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"170324","messageId":"20110620213904.11650.60345.stgit@localhost.localdomain","threadId":"27666","inReplyTo":null,"subject":"[PATCH] gitweb: 'pickaxe' feature requires 'search' enabled","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2011-06-20T21:40:07Z","receivedAt":"2011-06-20T21:40:07Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Signed-off-by: Jakub Narebski <jnareb@gmail.com>\n---\nThis is something I noticed when working on improving gitweb search.\n\n gitweb/gitweb.perl |    1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex c9e6426..1a59781 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -342,6 +342,7 @@ our %feature = (\n \t# Enable the pickaxe search, which will list the commits that modified\n \t# a given string in a file. This can be practical and quite faster\n \t# alternative to 'blame', but still potentially CPU-intensive.\n+\t# Note that you need to have 'search' feature enabled too.\n \n \t# To enable system wide have in $GITWEB_CONFIG\n \t# $feature{'pickaxe'}{'default'} = [1];\n"},{"id":"170355","messageId":"20110621064037.17169.36375.stgit@localhost.localdomain","threadId":"27666","inReplyTo":"20110620213904.11650.60345.stgit@localhost.localdomain","subject":"[PATCH (amend)] gitweb: 'pickaxe' and 'grep' features requires 'search' to be enabled","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2011-06-21T06:41:16Z","receivedAt":"2011-06-21T06:41:16Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Both 'pickaxe' (searching changes) and 'grep' (searching files)\nrequire basic 'search' feature to be enabled to work.  Enabling\ne.g. only 'pickaxe' won't work.\n\nAdd a comment about this.\n\nSigned-off-by: Jakub Narebski <jnareb@gmail.com>\n---\nI'm sorry, I forgot that this issue applies to 'grep' feature too.\n\n gitweb/gitweb.perl |    2 ++\n 1 files changed, 2 insertions(+), 0 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex c9e6426..63af8d4 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -328,6 +328,7 @@ our %feature = (\n \t# Enable grep search, which will list the files in currently selected\n \t# tree containing the given string. Enabled by default. This can be\n \t# potentially CPU-intensive, of course.\n+\t# Note that you need to have 'search' feature enabled too.\n \n \t# To enable system wide have in $GITWEB_CONFIG\n \t# $feature{'grep'}{'default'} = [1];\n@@ -342,6 +343,7 @@ our %feature = (\n \t# Enable the pickaxe search, which will list the commits that modified\n \t# a given string in a file. This can be practical and quite faster\n \t# alternative to 'blame', but still potentially CPU-intensive.\n+\t# Note that you need to have 'search' feature enabled too.\n \n \t# To enable system wide have in $GITWEB_CONFIG\n \t# $feature{'pickaxe'}{'default'} = [1];\n"}]}