threads / discuss / 27310

Qgit should use "git config" instead of "git repo-config"

Subject: Qgit should use "git config" instead of "git repo-config"

## tl;dr

7 messages between May 9, 2011 and May 14, 2011.

replies: 6people: 4as markdown or json

Jonathan Rogers· May 9, 2011, 21:20 UTC · lore

Here's a small patch to cause qgit to use "git config" instead of "git repo-config" in a couple of places.

-- 
Jonathan Ross Rogers




diff --git a/src/git.cpp b/src/git.cpp
index 50e6dd3..8e9365c 100644
--- a/src/git.cpp
+++ b/src/git.cpp
@@ -427,7 +427,7 @@ void Git::setTextCodec(QTextCodec* tc) {
 	if (name == "Big5-HKSCS")
 		name = "Big5";
 
-	run("git repo-config i18n.commitencoding " + name);
+	run("git config i18n.commitencoding " + name);
 }
 
 QTextCodec* Git::getTextCodec(bool* isGitArchive) {
@@ -437,7 +437,7 @@ QTextCodec* Git::getTextCodec(bool* isGitArchive) {
 		return NULL;
 
 	QString runOutput;
-	if (!run("git repo-config --get i18n.commitencoding", &runOutput))
+	if (!run("git config --get i18n.commitencoding", &runOutput))
 		return NULL;
 
 	if (runOutput.isEmpty()) // git docs says default is utf-8
Thiago Farina· May 9, 2011, 21:36 UTC · re: Jonathan Rogers · lore

Re: Qgit should use "git config" instead of "git repo-config"

On Mon, May 9, 2011 at 6:20 PM, Jonathan Rogers <jrogers@socialserve.com> wrote:
> Here's a small patch to cause qgit to use "git config" instead of "git
> repo-config" in a couple of places.
>

Please, read Documentation/SubmittingPatches for a guide about how to submit a patch to this list.

Thanks,
Best regards!
Show 5 quoted lines
> --
> Jonathan Ross Rogers
>
>
>
Jonathan Nieder· May 9, 2011, 23:19 UTC · re: Jonathan Rogers · lore

Re: Qgit should use "git config" instead of "git repo-config"

Hi Jonathan,
Jonathan Rogers wrote:
> Here's a small patch to cause qgit to use "git config" instead of
> "git repo-config" in a couple of places.
Thanks!  I noticed you also submitted this at [1].

Looking at the qgit source[2] I don't see an address to send patches to; cc-ing Marco for advice.

Hope that helps, Jonathan

[1] http://sourceforge.net/tracker/index.php?func=detail&aid=3299672&group_id=139897&atid=744829 [2] http://git.kernel.org/?p=qgit/qgit4.git

Jonathan Rogers· May 9, 2011, 23:35 UTC · re: Jonathan Nieder · lore

Re: Qgit should use "git config" instead of "git repo-config"

Jonathan Nieder wrote:
Show 10 quoted lines
> Hi Jonathan,
>
> Jonathan Rogers wrote:
>
>> Here's a small patch to cause qgit to use "git config" instead of
>> "git repo-config" in a couple of places.
> Thanks!  I noticed you also submitted this at [1].
>
> Looking at the qgit source[2] I don't see an address to send patches to;
> cc-ing Marco for advice.

Yes, this list is the only address listed in the docs that I found. It looks like some patches have been accepted on the SourceForge project have been accepted, but I'm not sure if that's the preferred location. Thanks for the help.

Show 5 quoted lines
> Hope that helps,
> Jonathan
>
> [1] http://sourceforge.net/tracker/index.php?func=detail&aid=3299672&group_id=139897&atid=744829
> [2] http://git.kernel.org/?p=qgit/qgit4.git
-- 
Jonathan Ross Rogers
Marco Costalba· May 14, 2011, 08:35 UTC · re: Jonathan Nieder · lore

Re: Qgit should use "git config" instead of "git repo-config"

On Tue, May 10, 2011 at 00:19, Jonathan Nieder <jrnieder@gmail.com> wrote:
Show 18 quoted lines
> Hi Jonathan,
>
> Jonathan Rogers wrote:
>
>> Here's a small patch to cause qgit to use "git config" instead of
>> "git repo-config" in a couple of places.
>
> Thanks!  I noticed you also submitted this at [1].
>
> Looking at the qgit source[2] I don't see an address to send patches to;
> cc-ing Marco for advice.
>
> Hope that helps,
> Jonathan
>
> [1] http://sourceforge.net/tracker/index.php?func=detail&aid=3299672&group_id=139897&atid=744829
> [2] http://git.kernel.org/?p=qgit/qgit4.git
>
Hi Jonathan,
   thanks for the patch, please send to git list (if other people
don't mind), I more or less routinely read the list. I really should
do at least some maintenance work on qgit that has gone vastly
bitrotten in the past months.....
Marco
Jonathan Nieder· May 14, 2011, 08:56 UTC · re: Marco Costalba · lore

Re: Qgit should use "git config" instead of "git repo-config"

Marco Costalba wrote:
>    thanks for the patch, please send to git list (if other people
> don't mind), I more or less routinely read the list. I really should
> do at least some maintenance work on qgit that has gone vastly
> bitrotten in the past months.....

Thanks. I don't know how I managed to miss that when skimming the README.

-- >8 --
Subject: Emphasize that patches go to the git list

So now even people with poor reading comprehension ability and search engines can tell where to send qgit improvements.

Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
 README |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/README b/README
index d1989ca..b07c463 100644
--- a/README
+++ b/README
@@ -4,7 +4,7 @@ qgit, a git GUI viewer
 With qgit you will be able to browse revisions history, view patch content
 and changed files, graphically following different development branches.
 
-Bugs or feature requests should be sent to the git@vger.kernel.org
+Bugs, patches, and feature requests should be sent to the git@vger.kernel.org
 mailing list.
 
 Main features

-- 
1.7.5.1
Thiago Farina· May 10, 2011, 00:11 UTC · lore

Re: Qgit should use "git config" instead of "git repo-config"

Please, don't forget to +cc the mailing list!
On Mon, May 9, 2011 at 8:31 PM, Jonathan Rogers <jrogers@socialserve.com> wrote:
Show 7 quoted lines
> Thiago Farina wrote:
>>
>> I think what he means by "Bugs or feature requests should be sent to
>> the git@vger.kernel.org mailing list." is?
>
> I don't understand the question.
>>
Ops, not a question. s/?/:
Show 21 quoted lines
>> Reporting bugs on git goes to this mailing list. If you have a
>> suggestion that you would wanted to see on the git core you could try
>> to send to this mailing list.
>>
>> He doesn't say that bug fixes and improvements to the source code of
>> qgit4 should be send to this mailing list. Patches sent here are for
>> the git source code at all if I'm not wrong.
>
> Since the README and author clearly state that the git@vger.kernel.org is
> the preferred place to discuss qgit, it's not clear to me where else is an
> appropriate place to send the patch.
>>>>
>>>> Maybe there is another list for qgit4?
>>>
>>> If there is, please share it with me.
>>
>> Maybe try to send a pull request on github or an email to the author?
>
> I also sent the patch to the author. The repository is on git.kernel.org, so
> I'm not sure how github would be involved.
>
I just saw this at: https://github.com/kaitanie/qgit4/
Show 6 quoted lines
> <URL:http://git.kernel.org/?p=qgit/qgit4.git;a=summary>
>
> --
> Jonathan Ross Rogers
>
>

← back to recent threads