# Qgit should use "git config" instead of "git repo-config" 7 messages from 2011-05-09 to 2011-05-14. Participants: Jonathan Rogers, Thiago Farina, Jonathan Nieder, Marco Costalba. Thread: https://gitlist.dev/t/27310 ## Jonathan Rogers, 2011-05-09 21:20 Subject: Qgit should use "git config" instead of "git repo-config" Message-ID: <4DC85AA7.2090502@socialserve.com> URL: https://gitlist.dev/e/4DC85AA7.2090502%40socialserve.com ``` Here's a small patch to cause qgit to use "git config" instead of "git repo-config" in a couple of places. -- Jonathan Ross Rogers diff --git a/src/git.cpp b/src/git.cpp index 50e6dd3..8e9365c 100644 --- a/src/git.cpp +++ b/src/git.cpp @@ -427,7 +427,7 @@ void Git::setTextCodec(QTextCodec* tc) { if (name == "Big5-HKSCS") name = "Big5"; - run("git repo-config i18n.commitencoding " + name); + run("git config i18n.commitencoding " + name); } QTextCodec* Git::getTextCodec(bool* isGitArchive) { @@ -437,7 +437,7 @@ QTextCodec* Git::getTextCodec(bool* isGitArchive) { return NULL; QString runOutput; - if (!run("git repo-config --get i18n.commitencoding", &runOutput)) + if (!run("git config --get i18n.commitencoding", &runOutput)) return NULL; if (runOutput.isEmpty()) // git docs says default is utf-8 ``` ## Thiago Farina, 2011-05-09 21:36 Subject: Re: Qgit should use "git config" instead of "git repo-config" Message-ID: URL: https://gitlist.dev/e/BANLkTikoViHF-AzfNwKkaYxsWhzvtRpvyw%40mail.gmail.com In-Reply-To: <4DC85AA7.2090502@socialserve.com> ``` On Mon, May 9, 2011 at 6:20 PM, Jonathan Rogers wrote: > Here's a small patch to cause qgit to use "git config" instead of "git > repo-config" in a couple of places. > Please, read Documentation/SubmittingPatches for a guide about how to submit a patch to this list. Thanks, Best regards! > -- > Jonathan Ross Rogers > > > ``` ## Jonathan Nieder, 2011-05-09 23:19 Subject: Re: Qgit should use "git config" instead of "git repo-config" Message-ID: <20110509231942.GA23781@elie> URL: https://gitlist.dev/e/20110509231942.GA23781%40elie In-Reply-To: <4DC85AA7.2090502@socialserve.com> ``` Hi Jonathan, Jonathan Rogers wrote: > Here's a small patch to cause qgit to use "git config" instead of > "git repo-config" in a couple of places. Thanks! I noticed you also submitted this at [1]. Looking at the qgit source[2] I don't see an address to send patches to; cc-ing Marco for advice. Hope that helps, Jonathan [1] http://sourceforge.net/tracker/index.php?func=detail&aid=3299672&group_id=139897&atid=744829 [2] http://git.kernel.org/?p=qgit/qgit4.git ``` ## Jonathan Rogers, 2011-05-09 23:35 Subject: Re: Qgit should use "git config" instead of "git repo-config" Message-ID: <4DC87A42.5000407@socialserve.com> URL: https://gitlist.dev/e/4DC87A42.5000407%40socialserve.com In-Reply-To: <20110509231942.GA23781@elie> ``` Jonathan Nieder wrote: > Hi Jonathan, > > Jonathan Rogers wrote: > >> Here's a small patch to cause qgit to use "git config" instead of >> "git repo-config" in a couple of places. > Thanks! I noticed you also submitted this at [1]. > > Looking at the qgit source[2] I don't see an address to send patches to; > cc-ing Marco for advice. Yes, this list is the only address listed in the docs that I found. It looks like some patches have been accepted on the SourceForge project have been accepted, but I'm not sure if that's the preferred location. Thanks for the help. > Hope that helps, > Jonathan > > [1] http://sourceforge.net/tracker/index.php?func=detail&aid=3299672&group_id=139897&atid=744829 > [2] http://git.kernel.org/?p=qgit/qgit4.git -- Jonathan Ross Rogers ``` ## Thiago Farina, 2011-05-10 00:11 Subject: Re: Qgit should use "git config" instead of "git repo-config" Message-ID: URL: https://gitlist.dev/e/BANLkTi%3DjsUwg7CgWfRr47Csq8yMeTKzO4w%40mail.gmail.com In-Reply-To: <4DC87943.6010805@socialserve.com> ``` Please, don't forget to +cc the mailing list! On Mon, May 9, 2011 at 8:31 PM, Jonathan Rogers wrote: > Thiago Farina wrote: >> >> I think what he means by "Bugs or feature requests should be sent to >> the git@vger.kernel.org mailing list." is? > > I don't understand the question. >> Ops, not a question. s/?/: >> Reporting bugs on git goes to this mailing list. If you have a >> suggestion that you would wanted to see on the git core you could try >> to send to this mailing list. >> >> He doesn't say that bug fixes and improvements to the source code of >> qgit4 should be send to this mailing list. Patches sent here are for >> the git source code at all if I'm not wrong. > > Since the README and author clearly state that the git@vger.kernel.org is > the preferred place to discuss qgit, it's not clear to me where else is an > appropriate place to send the patch. >>>> >>>> Maybe there is another list for qgit4? >>> >>> If there is, please share it with me. >> >> Maybe try to send a pull request on github or an email to the author? > > I also sent the patch to the author. The repository is on git.kernel.org, so > I'm not sure how github would be involved. > I just saw this at: https://github.com/kaitanie/qgit4/ > > > -- > Jonathan Ross Rogers > > ``` ## Marco Costalba, 2011-05-14 08:35 Subject: Re: Qgit should use "git config" instead of "git repo-config" Message-ID: URL: https://gitlist.dev/e/BANLkTin4kkzChJwh209SOD9-rJSiQxdGcQ%40mail.gmail.com In-Reply-To: <20110509231942.GA23781@elie> ``` On Tue, May 10, 2011 at 00:19, Jonathan Nieder wrote: > Hi Jonathan, > > Jonathan Rogers wrote: > >> Here's a small patch to cause qgit to use "git config" instead of >> "git repo-config" in a couple of places. > > Thanks!  I noticed you also submitted this at [1]. > > Looking at the qgit source[2] I don't see an address to send patches to; > cc-ing Marco for advice. > > Hope that helps, > Jonathan > > [1] http://sourceforge.net/tracker/index.php?func=detail&aid=3299672&group_id=139897&atid=744829 > [2] http://git.kernel.org/?p=qgit/qgit4.git > Hi Jonathan, thanks for the patch, please send to git list (if other people don't mind), I more or less routinely read the list. I really should do at least some maintenance work on qgit that has gone vastly bitrotten in the past months..... Marco ``` ## Jonathan Nieder, 2011-05-14 08:56 Subject: Re: Qgit should use "git config" instead of "git repo-config" Message-ID: <20110514085617.GA4891@elie> URL: https://gitlist.dev/e/20110514085617.GA4891%40elie In-Reply-To: ``` Marco Costalba wrote: > thanks for the patch, please send to git list (if other people > don't mind), I more or less routinely read the list. I really should > do at least some maintenance work on qgit that has gone vastly > bitrotten in the past months..... Thanks. I don't know how I managed to miss that when skimming the README. -- >8 -- Subject: Emphasize that patches go to the git list So now even people with poor reading comprehension ability and search engines can tell where to send qgit improvements. Signed-off-by: Jonathan Nieder --- README | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/README b/README index d1989ca..b07c463 100644 --- a/README +++ b/README @@ -4,7 +4,7 @@ qgit, a git GUI viewer With qgit you will be able to browse revisions history, view patch content and changed files, graphically following different development branches. -Bugs or feature requests should be sent to the git@vger.kernel.org +Bugs, patches, and feature requests should be sent to the git@vger.kernel.org mailing list. Main features -- 1.7.5.1 ```