{"thread":{"id":"27310","subject":"Qgit should use \"git config\" instead of \"git repo-config\"","startedAt":"2011-05-09T21:20:39Z","lastAt":"2011-05-14T08:56:46Z","messageCount":7,"participants":["Jonathan Rogers","Thiago Farina","Jonathan Nieder","Marco Costalba"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"167519","messageId":"4DC85AA7.2090502@socialserve.com","threadId":"27310","inReplyTo":null,"subject":"Qgit should use \"git config\" instead of \"git repo-config\"","fromName":"Jonathan Rogers","fromEmail":"jrogers@socialserve.com","sentAt":"2011-05-09T21:20:39Z","receivedAt":"2011-05-09T21:20:39Z","isPatch":false,"sender":{"key":"jrogers@socialserve.com","avatar":null},"body":"Here's a small patch to cause qgit to use \"git config\" instead of \"git \nrepo-config\" in a couple of places.\n\n-- \nJonathan Ross Rogers\n\n\n\n\ndiff --git a/src/git.cpp b/src/git.cpp\nindex 50e6dd3..8e9365c 100644\n--- a/src/git.cpp\n+++ b/src/git.cpp\n@@ -427,7 +427,7 @@ void Git::setTextCodec(QTextCodec* tc) {\n \tif (name == \"Big5-HKSCS\")\n \t\tname = \"Big5\";\n \n-\trun(\"git repo-config i18n.commitencoding \" + name);\n+\trun(\"git config i18n.commitencoding \" + name);\n }\n \n QTextCodec* Git::getTextCodec(bool* isGitArchive) {\n@@ -437,7 +437,7 @@ QTextCodec* Git::getTextCodec(bool* isGitArchive) {\n \t\treturn NULL;\n \n \tQString runOutput;\n-\tif (!run(\"git repo-config --get i18n.commitencoding\", &runOutput))\n+\tif (!run(\"git config --get i18n.commitencoding\", &runOutput))\n \t\treturn NULL;\n \n \tif (runOutput.isEmpty()) // git docs says default is utf-8\n\n"},{"id":"167520","messageId":"BANLkTikoViHF-AzfNwKkaYxsWhzvtRpvyw@mail.gmail.com","threadId":"27310","inReplyTo":"4DC85AA7.2090502@socialserve.com","subject":"Re: Qgit should use \"git config\" instead of \"git repo-config\"","fromName":"Thiago Farina","fromEmail":"tfransosi@gmail.com","sentAt":"2011-05-09T21:36:53Z","receivedAt":"2011-05-09T21:36:53Z","isPatch":false,"sender":{"key":"tfransosi@gmail.com","avatar":"https://avatars.githubusercontent.com/u/970071?v=4"},"body":"On Mon, May 9, 2011 at 6:20 PM, Jonathan Rogers wrote:\n> Here's a small patch to cause qgit to use \"git config\" instead of \"git\n> repo-config\" in a couple of places.\n>\nPlease, read Documentation/SubmittingPatches for a guide about how to\nsubmit a patch to this list.\n\nThanks,\n\nBest regards!\n\n> --\n> Jonathan Ross Rogers\n>\n>\n>\n"},{"id":"167552","messageId":"20110509231942.GA23781@elie","threadId":"27310","inReplyTo":"4DC85AA7.2090502@socialserve.com","subject":"Re: Qgit should use \"git config\" instead of \"git repo-config\"","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2011-05-09T23:19:42Z","receivedAt":"2011-05-09T23:19:42Z","isPatch":false,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Hi Jonathan,\n\nJonathan Rogers wrote:\n\n> Here's a small patch to cause qgit to use \"git config\" instead of\n> \"git repo-config\" in a couple of places.\n\nThanks! I noticed you also submitted this at [1].\n\nLooking at the qgit source[2] I don't see an address to send patches to;\ncc-ing Marco for advice.\n\nHope that helps,\nJonathan\n\n[1] http://sourceforge.net/tracker/index.php?func=detail&aid=3299672&group_id=139897&atid=744829\n[2] http://git.kernel.org/?p=qgit/qgit4.git\n"},{"id":"167557","messageId":"4DC87A42.5000407@socialserve.com","threadId":"27310","inReplyTo":"20110509231942.GA23781@elie","subject":"Re: Qgit should use \"git config\" instead of \"git repo-config\"","fromName":"Jonathan Rogers","fromEmail":"jrogers@socialserve.com","sentAt":"2011-05-09T23:35:30Z","receivedAt":"2011-05-09T23:35:30Z","isPatch":false,"sender":{"key":"jrogers@socialserve.com","avatar":null},"body":"Jonathan Nieder wrote:\n> Hi Jonathan,\n>\n> Jonathan Rogers wrote:\n>\n>> Here's a small patch to cause qgit to use \"git config\" instead of\n>> \"git repo-config\" in a couple of places.\n> Thanks! I noticed you also submitted this at [1].\n>\n> Looking at the qgit source[2] I don't see an address to send patches to;\n> cc-ing Marco for advice.\nYes, this list is the only address listed in the docs that I found. It \nlooks like some patches have been accepted on the SourceForge project \nhave been accepted, but I'm not sure if that's the preferred location.\nThanks for the help.\n> Hope that helps,\n> Jonathan\n>\n> [1] http://sourceforge.net/tracker/index.php?func=detail&aid=3299672&group_id=139897&atid=744829\n> [2] http://git.kernel.org/?p=qgit/qgit4.git\n-- \n\nJonathan Ross Rogers\n"},{"id":"167562","messageId":"BANLkTi=jsUwg7CgWfRr47Csq8yMeTKzO4w@mail.gmail.com","threadId":"27310","inReplyTo":"4DC87943.6010805@socialserve.com","subject":"Re: Qgit should use \"git config\" instead of \"git repo-config\"","fromName":"Thiago Farina","fromEmail":"tfransosi@gmail.com","sentAt":"2011-05-10T00:11:46Z","receivedAt":"2011-05-10T00:11:46Z","isPatch":false,"sender":{"key":"tfransosi@gmail.com","avatar":"https://avatars.githubusercontent.com/u/970071?v=4"},"body":"Please, don't forget to +cc the mailing list!\n\nOn Mon, May 9, 2011 at 8:31 PM, Jonathan Rogers wrote:\n> Thiago Farina wrote:\n>>\n>> I think what he means by \"Bugs or feature requests should be sent to\n>> the git@vger.kernel.org mailing list.\" is?\n>\n> I don't understand the question.\n>>\nOps, not a question. s/?/:\n\n>> Reporting bugs on git goes to this mailing list. If you have a\n>> suggestion that you would wanted to see on the git core you could try\n>> to send to this mailing list.\n>>\n>> He doesn't say that bug fixes and improvements to the source code of\n>> qgit4 should be send to this mailing list. Patches sent here are for\n>> the git source code at all if I'm not wrong.\n>\n> Since the README and author clearly state that the git@vger.kernel.org is\n> the preferred place to discuss qgit, it's not clear to me where else is an\n> appropriate place to send the patch.\n>>>>\n>>>> Maybe there is another list for qgit4?\n>>>\n>>> If there is, please share it with me.\n>>\n>> Maybe try to send a pull request on github or an email to the author?\n>\n> I also sent the patch to the author. The repository is on git.kernel.org, so\n> I'm not sure how github would be involved.\n>\nI just saw this at: https://github.com/kaitanie/qgit4/\n\n> \n>\n> --\n> Jonathan Ross Rogers\n>\n>\n"},{"id":"167836","messageId":"BANLkTin4kkzChJwh209SOD9-rJSiQxdGcQ@mail.gmail.com","threadId":"27310","inReplyTo":"20110509231942.GA23781@elie","subject":"Re: Qgit should use \"git config\" instead of \"git repo-config\"","fromName":"Marco Costalba","fromEmail":"mcostalba@gmail.com","sentAt":"2011-05-14T08:35:54Z","receivedAt":"2011-05-14T08:35:54Z","isPatch":false,"sender":{"key":"mcostalba@gmail.com","avatar":null},"body":"On Tue, May 10, 2011 at 00:19, Jonathan Nieder wrote:\n> Hi Jonathan,\n>\n> Jonathan Rogers wrote:\n>\n>> Here's a small patch to cause qgit to use \"git config\" instead of\n>> \"git repo-config\" in a couple of places.\n>\n> Thanks!  I noticed you also submitted this at [1].\n>\n> Looking at the qgit source[2] I don't see an address to send patches to;\n> cc-ing Marco for advice.\n>\n> Hope that helps,\n> Jonathan\n>\n> [1] http://sourceforge.net/tracker/index.php?func=detail&aid=3299672&group_id=139897&atid=744829\n> [2] http://git.kernel.org/?p=qgit/qgit4.git\n>\n\nHi Jonathan,\n\n thanks for the patch, please send to git list (if other people\ndon't mind), I more or less routinely read the list. I really should\ndo at least some maintenance work on qgit that has gone vastly\nbitrotten in the past months.....\n\nMarco\n"},{"id":"167837","messageId":"20110514085617.GA4891@elie","threadId":"27310","inReplyTo":"BANLkTin4kkzChJwh209SOD9-rJSiQxdGcQ@mail.gmail.com","subject":"Re: Qgit should use \"git config\" instead of \"git repo-config\"","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2011-05-14T08:56:46Z","receivedAt":"2011-05-14T08:56:46Z","isPatch":false,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Marco Costalba wrote:\n\n> thanks for the patch, please send to git list (if other people\n> don't mind), I more or less routinely read the list. I really should\n> do at least some maintenance work on qgit that has gone vastly\n> bitrotten in the past months.....\n\nThanks. I don't know how I managed to miss that when skimming the\nREADME.\n\n-- >8 --\nSubject: Emphasize that patches go to the git list\n\nSo now even people with poor reading comprehension ability and\nsearch engines can tell where to send qgit improvements.\n\nSigned-off-by: Jonathan Nieder \n---\n README | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/README b/README\nindex d1989ca..b07c463 100644\n--- a/README\n+++ b/README\n@@ -4,7 +4,7 @@ qgit, a git GUI viewer\n With qgit you will be able to browse revisions history, view patch content\n and changed files, graphically following different development branches.\n \n-Bugs or feature requests should be sent to the git@vger.kernel.org\n+Bugs, patches, and feature requests should be sent to the git@vger.kernel.org\n mailing list.\n \n Main features\n-- \n1.7.5.1\n"}]}