threads / patch / 26660

patchbuiltin/apply.c: remove impossible check

Subject: [PATCH] builtin/apply.c: remove impossible check

## tl;dr

One message between Mar 4, 2011 and Mar 4, 2011. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Nicolas Kaiser· Mar 4, 2011, 19:43 UTC · lore

'n1' and 'n2' are unsigned of type size_t, and can never be negative.

Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
---
Testsuite did not regress at my place.
 builtin/apply.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
Show changes to builtin/apply.c +0 −3
diff --git a/builtin/apply.c b/builtin/apply.c
index 14951da..6069377 100644
--- a/builtin/apply.c
+++ b/builtin/apply.c
@@ -248,9 +248,6 @@ static int fuzzy_matchlines(const char *s1, size_t n1,
 	const char *last2 = s2 + n2 - 1;
 	int result = 0;
 
-	if (n1 < 0 || n2 < 0)
-		return 0;
-
 	/* ignore line endings */
 	while ((*last1 == '\r') || (*last1 == '\n'))
 		last1--;
-- 
1.7.3.4

← back to recent threads