{"thread":{"id":"26660","subject":"[PATCH] builtin/apply.c: remove impossible check","startedAt":"2011-03-04T19:43:58Z","lastAt":"2011-03-04T19:43:58Z","messageCount":1,"participants":["Nicolas Kaiser"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"162790","messageId":"20110304204358.3f5618cf@absol.kitzblitz","threadId":"26660","inReplyTo":null,"subject":"[PATCH] builtin/apply.c: remove impossible check","fromName":"Nicolas Kaiser","fromEmail":"nikai@nikai.net","sentAt":"2011-03-04T19:43:58Z","receivedAt":"2011-03-04T19:43:58Z","isPatch":true,"sender":{"key":"nikai@nikai.net","avatar":"https://avatars.githubusercontent.com/u/494755?v=4"},"body":"'n1' and 'n2' are unsigned of type size_t, and can never\nbe negative.\n\nSigned-off-by: Nicolas Kaiser <nikai@nikai.net>\n---\nTestsuite did not regress at my place.\n\n builtin/apply.c |    3 ---\n 1 files changed, 0 insertions(+), 3 deletions(-)\n\ndiff --git a/builtin/apply.c b/builtin/apply.c\nindex 14951da..6069377 100644\n--- a/builtin/apply.c\n+++ b/builtin/apply.c\n@@ -248,9 +248,6 @@ static int fuzzy_matchlines(const char *s1, size_t n1,\n \tconst char *last2 = s2 + n2 - 1;\n \tint result = 0;\n \n-\tif (n1 < 0 || n2 < 0)\n-\t\treturn 0;\n-\n \t/* ignore line endings */\n \twhile ((*last1 == '\\r') || (*last1 == '\\n'))\n \t\tlast1--;\n-- \n1.7.3.4\n"}]}