git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] builtin/apply.c: remove impossible check

From
Nicolas Kaiser <nikai@nikai.net>
Date
Mar 4, 2011, 19:43 UTC
Message-ID
<20110304204358.3f5618cf@absol.kitzblitz>

'n1' and 'n2' are unsigned of type size_t, and can never be negative.

Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
---
Testsuite did not regress at my place.
 builtin/apply.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/builtin/apply.c b/builtin/apply.c
index 14951da..6069377 100644
--- a/builtin/apply.c
+++ b/builtin/apply.c
@@ -248,9 +248,6 @@ static int fuzzy_matchlines(const char *s1, size_t n1,
 	const char *last2 = s2 + n2 - 1;
 	int result = 0;
 
-	if (n1 < 0 || n2 < 0)
-		return 0;
-
 	/* ignore line endings */
 	while ((*last1 == '\r') || (*last1 == '\n'))
 		last1--;
-- 
1.7.3.4
Message 1 of 1 in “builtin/apply.c: remove impossible check”
  1. builtin/apply.c: remove impossible checkNicolas Kaiser, Mar 4, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.