threads / patch / 26372

patcht5526: Fix wrong argument order in "git config"

Subject: [PATCH] t5526: Fix wrong argument order in "git config"

## tl;dr

2 messages between Jan 31, 2011 and Feb 1, 2011. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Jens Lehmann· Jan 31, 2011, 16:51 UTC · lore

This fixes a typo where the "git config" arguments "-f" and "--unset" were swapped leading to the creation of a "--unset" file.

Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de>
---

Now that 1.7.4 is out and somebody else already stumbled across this typo I introduced ...

 t/t5526-fetch-submodules.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to t/t5526-fetch-submodules.sh +1 −1

diff --git a/t/t5526-fetch-submodules.sh b/t/t5526-fetch-submodules.sh
index 884a5e5..a5f4585 100755
--- a/t/t5526-fetch-submodules.sh
+++ b/t/t5526-fetch-submodules.sh
@@ -124,7 +124,7 @@ test_expect_success "--recurse-submodules overrides fetchRecurseSubmodules setti
 	(
 		cd downstream &&
 		git fetch --recurse-submodules >../actual.out 2>../actual.err &&
-		git config -f --unset .gitmodules submodule.submodule.fetchRecurseSubmodules true &&
+		git config --unset -f .gitmodules submodule.submodule.fetchRecurseSubmodules &&
 		git config --unset submodule.submodule.fetchRecurseSubmodules
 	) &&
 	test_cmp expect.out actual.out &&

-- 
1.7.3.4.27.g3921d.dirty

Junio C Hamano· Feb 1, 2011, 21:28 UTC · re: Jens Lehmann · lore

Re: [PATCH] t5526: Fix wrong argument order in "git config"

Jens Lehmann <Jens.Lehmann@web.de> writes:

Show 8 quoted lines

> This fixes a typo where the "git config" arguments "-f" and "--unset" were
> swapped leading to the creation of a "--unset" file.
>
> Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de>
> ---
>
> Now that 1.7.4 is out and somebody else already stumbled across this
> typo I introduced ...

Thanks.

Show 19 quoted lines

>
>  t/t5526-fetch-submodules.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/t/t5526-fetch-submodules.sh b/t/t5526-fetch-submodules.sh
> index 884a5e5..a5f4585 100755
> --- a/t/t5526-fetch-submodules.sh
> +++ b/t/t5526-fetch-submodules.sh
> @@ -124,7 +124,7 @@ test_expect_success "--recurse-submodules overrides fetchRecurseSubmodules setti
>  	(
>  		cd downstream &&
>  		git fetch --recurse-submodules >../actual.out 2>../actual.err &&
> -		git config -f --unset .gitmodules submodule.submodule.fetchRecurseSubmodules true &&
> +		git config --unset -f .gitmodules submodule.submodule.fetchRecurseSubmodules &&
>  		git config --unset submodule.submodule.fetchRecurseSubmodules
>  	) &&
>  	test_cmp expect.out actual.out &&
> -- 
> 1.7.3.4.27.g3921d.dirty