{"thread":{"id":"26372","subject":"[PATCH] t5526: Fix wrong argument order in \"git config\"","startedAt":"2011-01-31T16:51:25Z","lastAt":"2011-02-01T21:28:57Z","messageCount":2,"participants":["Jens Lehmann","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"160097","messageId":"4D46E88D.1020806@web.de","threadId":"26372","inReplyTo":null,"subject":"[PATCH] t5526: Fix wrong argument order in \"git config\"","fromName":"Jens Lehmann","fromEmail":"jens.lehmann@web.de","sentAt":"2011-01-31T16:51:25Z","receivedAt":"2011-01-31T16:51:25Z","isPatch":true,"sender":{"key":"jens.lehmann@web.de","avatar":"https://avatars.githubusercontent.com/u/135220?v=4"},"body":"This fixes a typo where the \"git config\" arguments \"-f\" and \"--unset\" were\nswapped leading to the creation of a \"--unset\" file.\n\nSigned-off-by: Jens Lehmann <Jens.Lehmann@web.de>\n---\n\nNow that 1.7.4 is out and somebody else already stumbled across this\ntypo I introduced ...\n\n t/t5526-fetch-submodules.sh |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/t/t5526-fetch-submodules.sh b/t/t5526-fetch-submodules.sh\nindex 884a5e5..a5f4585 100755\n--- a/t/t5526-fetch-submodules.sh\n+++ b/t/t5526-fetch-submodules.sh\n@@ -124,7 +124,7 @@ test_expect_success \"--recurse-submodules overrides fetchRecurseSubmodules setti\n \t(\n \t\tcd downstream &&\n \t\tgit fetch --recurse-submodules >../actual.out 2>../actual.err &&\n-\t\tgit config -f --unset .gitmodules submodule.submodule.fetchRecurseSubmodules true &&\n+\t\tgit config --unset -f .gitmodules submodule.submodule.fetchRecurseSubmodules &&\n \t\tgit config --unset submodule.submodule.fetchRecurseSubmodules\n \t) &&\n \ttest_cmp expect.out actual.out &&\n-- \n1.7.3.4.27.g3921d.dirty\n"},{"id":"160222","messageId":"7vk4hjzbom.fsf@alter.siamese.dyndns.org","threadId":"26372","inReplyTo":"4D46E88D.1020806@web.de","subject":"Re: [PATCH] t5526: Fix wrong argument order in \"git config\"","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-02-01T21:28:57Z","receivedAt":"2011-02-01T21:28:57Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jens Lehmann <Jens.Lehmann@web.de> writes:\n\n> This fixes a typo where the \"git config\" arguments \"-f\" and \"--unset\" were\n> swapped leading to the creation of a \"--unset\" file.\n>\n> Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de>\n> ---\n>\n> Now that 1.7.4 is out and somebody else already stumbled across this\n> typo I introduced ...\n\nThanks.\n\n>\n>  t/t5526-fetch-submodules.sh |    2 +-\n>  1 files changed, 1 insertions(+), 1 deletions(-)\n>\n> diff --git a/t/t5526-fetch-submodules.sh b/t/t5526-fetch-submodules.sh\n> index 884a5e5..a5f4585 100755\n> --- a/t/t5526-fetch-submodules.sh\n> +++ b/t/t5526-fetch-submodules.sh\n> @@ -124,7 +124,7 @@ test_expect_success \"--recurse-submodules overrides fetchRecurseSubmodules setti\n>  \t(\n>  \t\tcd downstream &&\n>  \t\tgit fetch --recurse-submodules >../actual.out 2>../actual.err &&\n> -\t\tgit config -f --unset .gitmodules submodule.submodule.fetchRecurseSubmodules true &&\n> +\t\tgit config --unset -f .gitmodules submodule.submodule.fetchRecurseSubmodules &&\n>  \t\tgit config --unset submodule.submodule.fetchRecurseSubmodules\n>  \t) &&\n>  \ttest_cmp expect.out actual.out &&\n> -- \n> 1.7.3.4.27.g3921d.dirty\n"}]}