# [PATCH] t5526: Fix wrong argument order in "git config" 2 messages from 2011-01-31 to 2011-02-01. Participants: Jens Lehmann, Junio C Hamano. Thread: https://gitlist.dev/t/26372 ## Jens Lehmann, 2011-01-31 16:51 Subject: [PATCH] t5526: Fix wrong argument order in "git config" Message-ID: <4D46E88D.1020806@web.de> URL: https://gitlist.dev/e/4D46E88D.1020806%40web.de ``` This fixes a typo where the "git config" arguments "-f" and "--unset" were swapped leading to the creation of a "--unset" file. Signed-off-by: Jens Lehmann --- Now that 1.7.4 is out and somebody else already stumbled across this typo I introduced ... t/t5526-fetch-submodules.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/t/t5526-fetch-submodules.sh b/t/t5526-fetch-submodules.sh index 884a5e5..a5f4585 100755 --- a/t/t5526-fetch-submodules.sh +++ b/t/t5526-fetch-submodules.sh @@ -124,7 +124,7 @@ test_expect_success "--recurse-submodules overrides fetchRecurseSubmodules setti ( cd downstream && git fetch --recurse-submodules >../actual.out 2>../actual.err && - git config -f --unset .gitmodules submodule.submodule.fetchRecurseSubmodules true && + git config --unset -f .gitmodules submodule.submodule.fetchRecurseSubmodules && git config --unset submodule.submodule.fetchRecurseSubmodules ) && test_cmp expect.out actual.out && -- 1.7.3.4.27.g3921d.dirty ``` ## Junio C Hamano, 2011-02-01 21:28 Subject: Re: [PATCH] t5526: Fix wrong argument order in "git config" Message-ID: <7vk4hjzbom.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vk4hjzbom.fsf%40alter.siamese.dyndns.org In-Reply-To: <4D46E88D.1020806@web.de> ``` Jens Lehmann writes: > This fixes a typo where the "git config" arguments "-f" and "--unset" were > swapped leading to the creation of a "--unset" file. > > Signed-off-by: Jens Lehmann > --- > > Now that 1.7.4 is out and somebody else already stumbled across this > typo I introduced ... Thanks. > > t/t5526-fetch-submodules.sh | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/t/t5526-fetch-submodules.sh b/t/t5526-fetch-submodules.sh > index 884a5e5..a5f4585 100755 > --- a/t/t5526-fetch-submodules.sh > +++ b/t/t5526-fetch-submodules.sh > @@ -124,7 +124,7 @@ test_expect_success "--recurse-submodules overrides fetchRecurseSubmodules setti > ( > cd downstream && > git fetch --recurse-submodules >../actual.out 2>../actual.err && > - git config -f --unset .gitmodules submodule.submodule.fetchRecurseSubmodules true && > + git config --unset -f .gitmodules submodule.submodule.fetchRecurseSubmodules && > git config --unset submodule.submodule.fetchRecurseSubmodules > ) && > test_cmp expect.out actual.out && > -- > 1.7.3.4.27.g3921d.dirty ```