[Bug] Gitweb corrupting files?

Hi,

It appears that Gitweb corrupts files when it is being used for creating compressed tarballs of sources.

A more precise description of the behaviour I'm experiencing is here: https://bugs.eclipse.org/bugs/show_bug.cgi?id=317882

Unfortunately I have no knowledge about the version in use at eclipse.org.

Thanks, Severin

On 01/12/2011 08:05 AM, Severin Gehwolf wrote:

That's a fairly old version of gitweb running (1.6.6.4), and it looks like it's stock gitweb (I.E. not the caching version). The file itself (the .bz2 anyway) is a valid, and complete .bz2, as well as the .tar file extracts cleanly.

That would indicate, that if there is corruption, it is happening in the git process itself that generates the tarball, and not in gitweb itself.

Best plan would be to upgrade to the latest code of gitweb and git and see if the problem still persists, and if it does be able to get us a tarball and url that has the corruption.

- John 'Warthog9' Hawley

Severin Gehwolf <jerboaa@gmail.com> writes:

E.g. http://egit.eclipse.org/w/?p=egit.git;a=snapshot;h=6b528445c3e543688b990e0a631c5f0238b02741;sf=tbz2 error in egit/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/BranchSelectionDialog.java

Couldn't you post summary of the above here?
 

It's git and gitweb version 1.6.4.4.

   And it built fine. Then, I tried checking out sources from command line using
   the git client:

   git clone git://egit.eclipse.org/egit.git egit
   cd egit

   git checkout 6b528445c3e543688b990e0a631c5f0238b02741
   cd ..
   tar -cjf egit_test.tar.bz2 egit

This should be

$ git archive --format=tar 6b528445c3e543688b990e0a631c5f0238b02741 |
  bzip2 > egit_test.tar.bz2

   just to make sure that it isn't a problem of how tarballs are created when
   using the above URL. It seems the file in the repository is corrupted (although
   I'm not entirely convinced).      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Git version 1.6.4.4 is long since fixing bug with not using ':raw' (binary) output layer with binary files. Also I don't see how it could have corrupted only 2 files, without making [compressed] archive un-compressable (invalid).

On Wed, Jan 12, 2011 at 1:05 PM, Jakub Narebski <jnareb@gmail.com> wrote:

I did some digging and it looks like somehow those files are indeed corrupt in the Git repo and it's not a Git or gitweb problem.

Thanks for responding!

--Severin