{"thread":{"id":"26267","subject":"[Bug] Gitweb corrupting files?","startedAt":"2011-01-12T16:05:27Z","lastAt":"2011-01-15T15:39:35Z","messageCount":4,"participants":["Severin Gehwolf","Jakub Narebski","J.H."],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"159405","messageId":"AANLkTim84sSWr=WRgjiY=Y3Mq7Tgojv9CpLrNjQMJfHR@mail.gmail.com","threadId":"26267","inReplyTo":null,"subject":"[Bug] Gitweb corrupting files?","fromName":"Severin Gehwolf","fromEmail":"jerboaa@gmail.com","sentAt":"2011-01-12T16:05:27Z","receivedAt":"2011-01-12T16:05:27Z","isPatch":false,"sender":{"key":"jerboaa@gmail.com","avatar":null},"body":"Hi,\n\nIt appears that Gitweb corrupts files when it is being used for\ncreating compressed tarballs of sources.\n\nA more precise description of the behaviour I'm experiencing is here:\nhttps://bugs.eclipse.org/bugs/show_bug.cgi?id=317882\n\nUnfortunately I have no knowledge about the version in use at eclipse.org.\n\nThanks,\nSeverin\n"},{"id":"159516","messageId":"4D2DE026.4080109@eaglescrag.net","threadId":"26267","inReplyTo":"AANLkTim84sSWr=WRgjiY=Y3Mq7Tgojv9CpLrNjQMJfHR@mail.gmail.com","subject":"Re: [Bug] Gitweb corrupting files?","fromName":"J.H.","fromEmail":"warthog9@eaglescrag.net","sentAt":"2011-01-12T17:08:54Z","receivedAt":"2011-01-12T17:08:54Z","isPatch":false,"sender":{"key":"warthog9@kernel.org","avatar":"https://avatars.githubusercontent.com/u/2334704?v=4"},"body":"On 01/12/2011 08:05 AM, Severin Gehwolf wrote:\n> Hi,\n> \n> It appears that Gitweb corrupts files when it is being used for\n> creating compressed tarballs of sources.\n> \n> A more precise description of the behaviour I'm experiencing is here:\n> https://bugs.eclipse.org/bugs/show_bug.cgi?id=317882\n> \n> Unfortunately I have no knowledge about the version in use at eclipse.org.\n\nThat's a fairly old version of gitweb running (1.6.6.4), and it looks\nlike it's stock gitweb (I.E. not the caching version). The file itself\n(the .bz2 anyway) is a valid, and complete .bz2, as well as the .tar\nfile extracts cleanly.\n\nThat would indicate, that if there is corruption, it is happening in the\ngit process itself that generates the tarball, and not in gitweb itself.\n\nBest plan would be to upgrade to the latest code of gitweb and git and\nsee if the problem still persists, and if it does be able to get us a\ntarball and url that has the corruption.\n\n- John 'Warthog9' Hawley\n"},{"id":"159409","messageId":"m3hbdeatgn.fsf@localhost.localdomain","threadId":"26267","inReplyTo":"AANLkTim84sSWr=WRgjiY=Y3Mq7Tgojv9CpLrNjQMJfHR@mail.gmail.com","subject":"Re: [Bug] Gitweb corrupting files?","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2011-01-12T18:05:45Z","receivedAt":"2011-01-12T18:05:45Z","isPatch":false,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Severin Gehwolf writes:\n\n> It appears that Gitweb corrupts files when it is being used for\n> creating compressed tarballs of sources.\n\nE.g. http://egit.eclipse.org/w/?p=egit.git;a=snapshot;h=6b528445c3e543688b990e0a631c5f0238b02741;sf=tbz2\nerror in egit/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/BranchSelectionDialog.java\n\n> A more precise description of the behaviour I'm experiencing is here:\n> https://bugs.eclipse.org/bugs/show_bug.cgi?id=317882\n\nCouldn't you post summary of the above here?\n \n> Unfortunately I have no knowledge about the version in use at eclipse.org.\n\nIt's git and gitweb version 1.6.4.4.\n\n\n>From original bugreport:\n\n And it built fine. Then, I tried checking out sources from command line using\n the git client:\n\n git clone git://egit.eclipse.org/egit.git egit\n cd egit\n\n git checkout 6b528445c3e543688b990e0a631c5f0238b02741\n cd ..\n tar -cjf egit_test.tar.bz2 egit\n\nThis should be\n\n$ git archive --format=tar 6b528445c3e543688b990e0a631c5f0238b02741 |\n bzip2 > egit_test.tar.bz2\n\n just to make sure that it isn't a problem of how tarballs are created when\n using the above URL. It seems the file in the repository is corrupted (although\n I'm not entirely convinced). ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n\nGit version 1.6.4.4 is long since fixing bug with not using ':raw'\n(binary) output layer with binary files. Also I don't see how it\ncould have corrupted only 2 files, without making [compressed] archive\nun-compressable (invalid).\n\n-- \nJakub Narebski\nPoland\nShadeHawk on #git\n"},{"id":"159530","messageId":"AANLkTinY8_maXxP_19hiugiNck=2HELZmurERgwry5H0@mail.gmail.com","threadId":"26267","inReplyTo":"m3hbdeatgn.fsf@localhost.localdomain","subject":"Re: [Not a] [Bug] Gitweb corrupting files?","fromName":"Severin Gehwolf","fromEmail":"jerboaa@gmail.com","sentAt":"2011-01-15T15:39:35Z","receivedAt":"2011-01-15T15:39:35Z","isPatch":false,"sender":{"key":"jerboaa@gmail.com","avatar":null},"body":"On Wed, Jan 12, 2011 at 1:05 PM, Jakub Narebski wrote:\n> Severin Gehwolf writes:\n>\n>> It appears that Gitweb corrupts files when it is being used for\n>> creating compressed tarballs of sources.\n>\n> E.g. http://egit.eclipse.org/w/?p=egit.git;a=snapshot;h=6b528445c3e543688b990e0a631c5f0238b02741;sf=tbz2\n> error in egit/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/BranchSelectionDialog.java\n>\n>> A more precise description of the behaviour I'm experiencing is here:\n>> https://bugs.eclipse.org/bugs/show_bug.cgi?id=317882\n>\n> Couldn't you post summary of the above here?\n>\n>> Unfortunately I have no knowledge about the version in use at eclipse.org.\n>\n> It's git and gitweb version 1.6.4.4.\n>\n>\n> From original bugreport:\n>\n>   And it built fine. Then, I tried checking out sources from command line using\n>   the git client:\n>\n>   git clone git://egit.eclipse.org/egit.git egit\n>   cd egit\n>\n>   git checkout 6b528445c3e543688b990e0a631c5f0238b02741\n>   cd ..\n>   tar -cjf egit_test.tar.bz2 egit\n>\n> This should be\n>\n> $ git archive --format=tar 6b528445c3e543688b990e0a631c5f0238b02741 |\n>  bzip2 > egit_test.tar.bz2\n\nI did some digging and it looks like somehow those files are indeed\ncorrupt in the Git repo and it's not a Git or gitweb problem.\n\nThanks for responding!\n\n--Severin\n"}]}