# [Bug] Gitweb corrupting files? 4 messages from 2011-01-12 to 2011-01-15. Participants: Severin Gehwolf, Jakub Narebski, J.H.. Thread: https://gitlist.dev/t/26267 ## Severin Gehwolf, 2011-01-12 16:05 Subject: [Bug] Gitweb corrupting files? Message-ID: URL: https://gitlist.dev/e/AANLkTim84sSWr%3DWRgjiY%3DY3Mq7Tgojv9CpLrNjQMJfHR%40mail.gmail.com ``` Hi, It appears that Gitweb corrupts files when it is being used for creating compressed tarballs of sources. A more precise description of the behaviour I'm experiencing is here: https://bugs.eclipse.org/bugs/show_bug.cgi?id=317882 Unfortunately I have no knowledge about the version in use at eclipse.org. Thanks, Severin ``` ## J.H., 2011-01-12 17:08 Subject: Re: [Bug] Gitweb corrupting files? Message-ID: <4D2DE026.4080109@eaglescrag.net> URL: https://gitlist.dev/e/4D2DE026.4080109%40eaglescrag.net In-Reply-To: ``` On 01/12/2011 08:05 AM, Severin Gehwolf wrote: > Hi, > > It appears that Gitweb corrupts files when it is being used for > creating compressed tarballs of sources. > > A more precise description of the behaviour I'm experiencing is here: > https://bugs.eclipse.org/bugs/show_bug.cgi?id=317882 > > Unfortunately I have no knowledge about the version in use at eclipse.org. That's a fairly old version of gitweb running (1.6.6.4), and it looks like it's stock gitweb (I.E. not the caching version). The file itself (the .bz2 anyway) is a valid, and complete .bz2, as well as the .tar file extracts cleanly. That would indicate, that if there is corruption, it is happening in the git process itself that generates the tarball, and not in gitweb itself. Best plan would be to upgrade to the latest code of gitweb and git and see if the problem still persists, and if it does be able to get us a tarball and url that has the corruption. - John 'Warthog9' Hawley ``` ## Jakub Narebski, 2011-01-12 18:05 Subject: Re: [Bug] Gitweb corrupting files? Message-ID: URL: https://gitlist.dev/e/m3hbdeatgn.fsf%40localhost.localdomain In-Reply-To: ``` Severin Gehwolf writes: > It appears that Gitweb corrupts files when it is being used for > creating compressed tarballs of sources. E.g. http://egit.eclipse.org/w/?p=egit.git;a=snapshot;h=6b528445c3e543688b990e0a631c5f0238b02741;sf=tbz2 error in egit/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/BranchSelectionDialog.java > A more precise description of the behaviour I'm experiencing is here: > https://bugs.eclipse.org/bugs/show_bug.cgi?id=317882 Couldn't you post summary of the above here? > Unfortunately I have no knowledge about the version in use at eclipse.org. It's git and gitweb version 1.6.4.4. >From original bugreport: And it built fine. Then, I tried checking out sources from command line using the git client: git clone git://egit.eclipse.org/egit.git egit cd egit git checkout 6b528445c3e543688b990e0a631c5f0238b02741 cd .. tar -cjf egit_test.tar.bz2 egit This should be $ git archive --format=tar 6b528445c3e543688b990e0a631c5f0238b02741 | bzip2 > egit_test.tar.bz2 just to make sure that it isn't a problem of how tarballs are created when using the above URL. It seems the file in the repository is corrupted (although I'm not entirely convinced). ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Git version 1.6.4.4 is long since fixing bug with not using ':raw' (binary) output layer with binary files. Also I don't see how it could have corrupted only 2 files, without making [compressed] archive un-compressable (invalid). -- Jakub Narebski Poland ShadeHawk on #git ``` ## Severin Gehwolf, 2011-01-15 15:39 Subject: Re: [Not a] [Bug] Gitweb corrupting files? Message-ID: URL: https://gitlist.dev/e/AANLkTinY8_maXxP_19hiugiNck%3D2HELZmurERgwry5H0%40mail.gmail.com In-Reply-To: ``` On Wed, Jan 12, 2011 at 1:05 PM, Jakub Narebski wrote: > Severin Gehwolf writes: > >> It appears that Gitweb corrupts files when it is being used for >> creating compressed tarballs of sources. > > E.g. http://egit.eclipse.org/w/?p=egit.git;a=snapshot;h=6b528445c3e543688b990e0a631c5f0238b02741;sf=tbz2 > error in egit/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/BranchSelectionDialog.java > >> A more precise description of the behaviour I'm experiencing is here: >> https://bugs.eclipse.org/bugs/show_bug.cgi?id=317882 > > Couldn't you post summary of the above here? > >> Unfortunately I have no knowledge about the version in use at eclipse.org. > > It's git and gitweb version 1.6.4.4. > > > From original bugreport: > >   And it built fine. Then, I tried checking out sources from command line using >   the git client: > >   git clone git://egit.eclipse.org/egit.git egit >   cd egit > >   git checkout 6b528445c3e543688b990e0a631c5f0238b02741 >   cd .. >   tar -cjf egit_test.tar.bz2 egit > > This should be > > $ git archive --format=tar 6b528445c3e543688b990e0a631c5f0238b02741 | >  bzip2 > egit_test.tar.bz2 I did some digging and it looks like somehow those files are indeed corrupt in the Git repo and it's not a Git or gitweb problem. Thanks for responding! --Severin ```