threads / patch / 26253

patchexec_cmd: remove unused extern

Subject: [PATCH] exec_cmd: remove unused extern

## tl;dr

3 messages between Jan 10, 2011 and Mar 24, 2011. Diffs are folded; open one to read it.

replies: 2people: 1as markdown or json

Erik Faye-Lund· Jan 10, 2011, 22:00 UTC · lore

This definition was added by commit 77cb17e9, but it's left unused since commit 511707d. Remove the left-over definition.

Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
---

Just a left-over definition I found while looking through some code.

 exec_cmd.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

Show changes to exec_cmd.c +0 −1

diff --git a/exec_cmd.c b/exec_cmd.c
index bf22570..38545e8 100644
--- a/exec_cmd.c
+++ b/exec_cmd.c
@@ -3,7 +3,6 @@
 #include "quote.h"
 #define MAX_ARGS	32
 
-extern char **environ;
 static const char *argv_exec_path;
 static const char *argv0_path;

-- 
1.7.4.rc1.3196.gfd693

Erik Faye-Lund· Mar 24, 2011, 10:39 UTC · re: Erik Faye-Lund · lore

Re: [PATCH] exec_cmd: remove unused extern

On Mon, Jan 10, 2011 at 11:00 PM, Erik Faye-Lund <kusmabite@gmail.com> wrote:

Show 23 quoted lines

> This definition was added by commit 77cb17e9, but it's left unused since
> commit 511707d. Remove the left-over definition.
>
> Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
> ---
>
> Just a left-over definition I found while looking through some code.
>
>  exec_cmd.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/exec_cmd.c b/exec_cmd.c
> index bf22570..38545e8 100644
> --- a/exec_cmd.c
> +++ b/exec_cmd.c
> @@ -3,7 +3,6 @@
>  #include "quote.h"
>  #define MAX_ARGS       32
>
> -extern char **environ;
>  static const char *argv_exec_path;
>  static const char *argv0_path;
>

Bump? Or is this just too insignificant?

Erik Faye-Lund· Mar 24, 2011, 10:44 UTC · re: Erik Faye-Lund · lore

Re: [PATCH] exec_cmd: remove unused extern

On Thu, Mar 24, 2011 at 11:39 AM, Erik Faye-Lund <kusmabite@gmail.com> wrote:

Show 27 quoted lines

> On Mon, Jan 10, 2011 at 11:00 PM, Erik Faye-Lund <kusmabite@gmail.com> wrote:
>> This definition was added by commit 77cb17e9, but it's left unused since
>> commit 511707d. Remove the left-over definition.
>>
>> Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
>> ---
>>
>> Just a left-over definition I found while looking through some code.
>>
>>  exec_cmd.c |    1 -
>>  1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/exec_cmd.c b/exec_cmd.c
>> index bf22570..38545e8 100644
>> --- a/exec_cmd.c
>> +++ b/exec_cmd.c
>> @@ -3,7 +3,6 @@
>>  #include "quote.h"
>>  #define MAX_ARGS       32
>>
>> -extern char **environ;
>>  static const char *argv_exec_path;
>>  static const char *argv0_path;
>>
>
> Bump? Or is this just too insignificant?
>

Sorry for the noise. This has already been applied, I just experienced a brain fart while checking.