# [PATCH] exec_cmd: remove unused extern 3 messages from 2011-01-10 to 2011-03-24. Participants: Erik Faye-Lund. Thread: https://gitlist.dev/t/26253 ## Erik Faye-Lund, 2011-01-10 22:00 Subject: [PATCH] exec_cmd: remove unused extern Message-ID: <1294696849-1428-1-git-send-email-kusmabite@gmail.com> URL: https://gitlist.dev/e/1294696849-1428-1-git-send-email-kusmabite%40gmail.com ``` This definition was added by commit 77cb17e9, but it's left unused since commit 511707d. Remove the left-over definition. Signed-off-by: Erik Faye-Lund --- Just a left-over definition I found while looking through some code. exec_cmd.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/exec_cmd.c b/exec_cmd.c index bf22570..38545e8 100644 --- a/exec_cmd.c +++ b/exec_cmd.c @@ -3,7 +3,6 @@ #include "quote.h" #define MAX_ARGS 32 -extern char **environ; static const char *argv_exec_path; static const char *argv0_path; -- 1.7.4.rc1.3196.gfd693 ``` ## Erik Faye-Lund, 2011-03-24 10:39 Subject: Re: [PATCH] exec_cmd: remove unused extern Message-ID: URL: https://gitlist.dev/e/AANLkTinhknijHo9Qo%3Drqik3ksjT27AVSLhcac-tGByx9%40mail.gmail.com In-Reply-To: <1294696849-1428-1-git-send-email-kusmabite@gmail.com> ``` On Mon, Jan 10, 2011 at 11:00 PM, Erik Faye-Lund wrote: > This definition was added by commit 77cb17e9, but it's left unused since > commit 511707d. Remove the left-over definition. > > Signed-off-by: Erik Faye-Lund > --- > > Just a left-over definition I found while looking through some code. > >  exec_cmd.c |    1 - >  1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/exec_cmd.c b/exec_cmd.c > index bf22570..38545e8 100644 > --- a/exec_cmd.c > +++ b/exec_cmd.c > @@ -3,7 +3,6 @@ >  #include "quote.h" >  #define MAX_ARGS       32 > > -extern char **environ; >  static const char *argv_exec_path; >  static const char *argv0_path; > Bump? Or is this just too insignificant? ``` ## Erik Faye-Lund, 2011-03-24 10:44 Subject: Re: [PATCH] exec_cmd: remove unused extern Message-ID: URL: https://gitlist.dev/e/AANLkTimgYHGAebKeZyqnM99UBw%3D_ML0AVHY2oZgy%2B08o%40mail.gmail.com In-Reply-To: ``` On Thu, Mar 24, 2011 at 11:39 AM, Erik Faye-Lund wrote: > On Mon, Jan 10, 2011 at 11:00 PM, Erik Faye-Lund wrote: >> This definition was added by commit 77cb17e9, but it's left unused since >> commit 511707d. Remove the left-over definition. >> >> Signed-off-by: Erik Faye-Lund >> --- >> >> Just a left-over definition I found while looking through some code. >> >>  exec_cmd.c |    1 - >>  1 files changed, 0 insertions(+), 1 deletions(-) >> >> diff --git a/exec_cmd.c b/exec_cmd.c >> index bf22570..38545e8 100644 >> --- a/exec_cmd.c >> +++ b/exec_cmd.c >> @@ -3,7 +3,6 @@ >>  #include "quote.h" >>  #define MAX_ARGS       32 >> >> -extern char **environ; >>  static const char *argv_exec_path; >>  static const char *argv0_path; >> > > Bump? Or is this just too insignificant? > Sorry for the noise. This has already been applied, I just experienced a brain fart while checking. ```